workload/indexes: support insert and update workloads#109907
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 1, 2023
Merged
workload/indexes: support insert and update workloads#109907craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This commit adds support for Insert and Update statements in the indexes workload. Insert statements will fail if they find a collision and update statements will fail if they don't, so each workload has specific requirements, which are documented on the flag. Epic: None Release note: None
Member
|
This change is |
DrewKimball
approved these changes
Sep 1, 2023
Collaborator
DrewKimball
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @renatolabs and @smg260)
srosenberg
approved these changes
Sep 1, 2023
Member
srosenberg
left a comment
There was a problem hiding this comment.
Thanks for adding these! I am curious what prompted the change?
Contributor
Author
|
TFTRs! bors r=DrewKimball,srosenberg
Drew and I are working on measuring the performance characteristics of secondary indexes on different workloads. It turns out that UPSERT is not a great place to start for these kinds of measurements, because it exploits a fast-path for the single-index case which is not applicable to other workload shapes. |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for Insert and Update statements in the indexes workload. Insert statements will fail if they find a collision and update statements will fail if they don't, so each workload has specific requirements, which are documented on the flag.
Epic: None
Release note: None