jobs: add a reference to the resumer in the claimed jobs map#109826
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 1, 2023
Merged
jobs: add a reference to the resumer in the claimed jobs map#109826craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
dt
approved these changes
Aug 31, 2023
pkg/jobs/registry_test.go
Outdated
|
|
||
| ctx := context.Background() | ||
| intervalOverride := time.Millisecond | ||
| s, _, _ := serverutils.StartServer(t, base.TestServerArgs{ |
This change adds a reference to the resumer in the map maintained by every registry of the jobs that it has claimed. This will be used in a follow up commit to request the resumer to dump its job profiler details on demand as explained in Informs: cockroachdb#109671 Release note: None
4195895 to
3f69413
Compare
Contributor
Author
|
@msbutler is investigating the slow quiesce but its unrelated to this PR so merging this. bors r=dt |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a reference to the resumer in the map maintained by every registry of the jobs that it has claimed. This will be used in a follow up commit to request the resumer to dump its job profiler details on demand as explained in
Informs: #109671
Release note: None