-
Notifications
You must be signed in to change notification settings - Fork 4.1k
sql/kv: remove all uses of keyutils.TestingSQLCodec (previously keys.TODOSQLCodec) #48123
Copy link
Copy link
Labels
A-multitenancyRelated to multi-tenancyRelated to multi-tenancyC-cleanupTech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.T-kvKV TeamKV Team
Description
We want to remove uses of keysutils.TestingSQLCodec (previously keys.TODOSQLCodec) then remove that codec altogether.
Dependencies:
-
Feature work:
- table/db details in admin server HTTP API server: the TableDetails, TableStats, DatabaseDetails API don't decode with a proper tenant prefix #82879
-
cockroach debug backup exportbackupccl:debug backup exportnot tested (maybe not working) for tenant backups #82878 - KV replication reports kvserver/reports: SREs can't use replication reports to check application of tenant zone configs #82881 - use renamed to
FIXMEIDONTKNOWWHICHCODECTOUSEin *: identify remaining uses of TODOSQLCodec #99774
-
Test code:
- backup TestPublicIndexTableSpans, check two keyspaces backupccl: TestPublicIndexTableSpans should exercise secondary tenant keyspans #82882
- tenant streaming TestRandomClientGeneration, plumb proper codec streamingest: TestRandomClientGeneration should use the proper SQLCodec in
assertEqualKVs()#82883 - columnar execution, TestSpanAssembler, check two keyspaces colexecspan: TestSpanAssembler should exercise guest tenant keyspaces #82884
- row / jobs, TestJobBackedSeqChunkProvider, plumb proper codec sql/row: TestJobBackedSeqChunkProvider incorrectly uses keys.TODOSQLCodec #82886
- keysutils/pretty_scanner (used by replication reports), plumb proper codec server: allow users to run conformance reports for their schemas #100004 / kvserver/reports: SREs can't use replication reports to check application of tenant zone configs #82881
Jira issue: CRDB-4356
Epic: CRDB-26091
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-multitenancyRelated to multi-tenancyRelated to multi-tenancyC-cleanupTech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.T-kvKV TeamKV Team