keysutils: remove TestingSQLCodec#104845
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Jun 15, 2023
Merged
Conversation
Member
|
This change is |
bff65bc to
fe1327d
Compare
Epic: None Release note: None
This commit extends `MakePrettyScannerForNamedTables` to support keys from the secondary tenants' key space, thus, removing the last usage of `TestingSQLCodec`. The way this is achieved is similar to how we overwrite the tableKeyParse function for `/Table` prefix in the dictionary - in this commit, we overwrite the tenantKeyParse function for `/Tenant` prefix. Release note: None
fe1327d to
2485688
Compare
knz
approved these changes
Jun 15, 2023
Contributor
knz
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 10 of 10 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @stevendanna)
Member
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
server: use server's codec instead of TestingSQLCodec in some tests
Release note: None
keysutils: extend MakePrettyScannerForNamedTables to support tenants
This commit extends
MakePrettyScannerForNamedTablesto support keys from the secondary tenants' key space, thus, removing the last usage ofTestingSQLCodec. The way this is achieved is similar to how we overwrite the tableKeyParse function for/Tableprefix in the dictionary - in this commit, we overwrite the tenantKeyParse function for/Tenantprefix.Release note: None
Fixes: #48123.