-
Notifications
You must be signed in to change notification settings - Fork 4.1k
sql/row: TestJobBackedSeqChunkProvider incorrectly uses keys.TODOSQLCodec #82886
Copy link
Copy link
Closed
Closed
Copy link
Labels
A-disaster-recoveryA-multitenancyRelated to multi-tenancyRelated to multi-tenancyA-testingTesting tools and infrastructureTesting tools and infrastructureC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-disaster-recovery
Description
Forked from #48123.
Describe the problem
In TestJobBackedSeqChunkProvider, (sql/row/expr_walker_test.go), an eval.Context is instantiated near the top with keys.TODOSQLCodec. This is incorrect.
Expected behavior
Instead, the test should bind the eval.Context to the SQLCodec coming from the TestServer.
(After #76582, this will be automatically and probabilistically assinged to either a system tenant codec or a secondary tenant codec.)
cc @adityamaru for triage
Jira issue: CRDB-16712
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-disaster-recoveryA-multitenancyRelated to multi-tenancyRelated to multi-tenancyA-testingTesting tools and infrastructureTesting tools and infrastructureC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-disaster-recovery