*: identify remaining uses of TODOSQLCodec#99774
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 28, 2023
Merged
*: identify remaining uses of TODOSQLCodec#99774craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
The `TODOSQLCodec` was a bug waiting to happen. The only reasonable remaining purpose is for use in tests. As such, this change moves its definition to a test-only package (we have a linter that verifies that `testutils` is not included in non-test code). This change then identifies the one non-reasonable remaining purposes and identifies it properly as a bug linked to cockroachdb#48123. Release note: None
Member
|
This change is |
stevendanna
approved these changes
Mar 28, 2023
Collaborator
stevendanna
left a comment
There was a problem hiding this comment.
Thanks for reviewing all the uses of this. Nice to see we only have one non-test use.
8 tasks
Contributor
Author
|
TFYR! bors r=stevendanna |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TODOSQLCodecwas a bug waiting to happen.The only reasonable remaining purpose is for use in tests. As such, this change moves its definition to a test-only package (we have a linter that verifies that
testutilsis not included in non-test code).This change then identifies the one non-reasonable remaining purposes and identifies it properly as a bug linked to #48123.
Release note: None
Epic: None