-
Notifications
You must be signed in to change notification settings - Fork 4.1k
backupccl: debug backup export not tested (maybe not working) for tenant backups #82878
Copy link
Copy link
Closed
Closed
Copy link
Labels
A-disaster-recoveryA-multitenancyRelated to multi-tenancyRelated to multi-tenancyC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-disaster-recovery
Description
Describe the problem
When we look at the implementation of cockroach backup export we see that it uses keys.TODOSQLCodec to report the contents of a backup.
This is not likely to work if the backup files contain data for a tenant.
In addition, we see that backup export is not being tested for tenant backups in ccl/cliccl, alongside the other cases in debug_backup_test.go.
Expected behavior
There are passing unit tests in ccl/cliccl that exercise debug backup export for tenant backups.
cc @stevendanna for triage
Jira issue: CRDB-16703
Epic: CRDB-14582
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-disaster-recoveryA-multitenancyRelated to multi-tenancyRelated to multi-tenancyC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-disaster-recovery