Skip to content

feat(aws): Remove more codegen#6853

Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
disq:chore/aws-remove-more-codegen
Jan 16, 2023
Merged

feat(aws): Remove more codegen#6853
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
disq:chore/aws-remove-more-codegen

Conversation

@disq
Copy link
Copy Markdown
Member

@disq disq commented Jan 16, 2023

No more "codegen" in resources/ now.

@github-actions
Copy link
Copy Markdown

This PR has the following changes to source plugin(s) tables:

  • Table aws_cloudwatch_alarms: column added with name alarm_arn and type String
  • Table aws_ec2_transit_gateway_vpc_attachments: column order changed for tags
  • Table aws_ecs_cluster_container_instances: column order changed for tags
  • Table aws_iot_security_profiles: column added with name security_profile_arn and type String

Copy link
Copy Markdown
Member

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think this is a feat as it adds new columns (I'm assuming we generated the tables from the wrong struct?)

@disq
Copy link
Copy Markdown
Member Author

disq commented Jan 16, 2023

Looks good, I think this is a feat as it adds new columns (I'm assuming we generated the tables from the wrong struct?)

No, it's not a wrong struct, just that alarm_arn (and security_profile_arn) was in skip fields (in codegen) before, but now as a design decision we don't skip those fields and prefer to have duplicate arn columns (same with all other transformer generated resources).

@erezrokah
Copy link
Copy Markdown
Member

No, it's not a wrong struct, just that alarm_arn (and security_profile_arn) was in skip fields (in codegen) before, but now as a design decision we don't skip those fields and prefer to have duplicate arn columns (same with all other transformer generated resources).

Cool, thanks for the context. But should this still be a feat? It's a user facing change

@disq disq changed the title chore(aws): Remove more codegen feat(aws): Remove more codegen Jan 16, 2023
@disq
Copy link
Copy Markdown
Member Author

disq commented Jan 16, 2023

No, it's not a wrong struct, just that alarm_arn (and security_profile_arn) was in skip fields (in codegen) before, but now as a design decision we don't skip those fields and prefer to have duplicate arn columns (same with all other transformer generated resources).

Cool, thanks for the context. But should this still be a feat? It's a user facing change

Sure, updated. But I don't believe it's a very important change.

@yevgenypats yevgenypats added the automerge Automatically merge once required checks pass label Jan 16, 2023
@kodiakhq kodiakhq bot merged commit 795e40d into cloudquery:main Jan 16, 2023
@disq disq deleted the chore/aws-remove-more-codegen branch January 17, 2023 00:11
kodiakhq bot pushed a commit that referenced this pull request Jan 18, 2023
🤖 I have created a release *beep* *boop*
---


## [12.0.0](plugins-source-aws-v11.0.1...plugins-source-aws-v12.0.0) (2023-01-18)


### ⚠ BREAKING CHANGES

* **aws:** Add region to `aws_backup_global_settings` primary key ([#6844](#6844))
* **aws:** Remove redundant fields from `aws_lambda_runtimes` ([#6849](#6849))
* **aws:** Add `region` to `aws_docdb_engine_versions` primary key ([#6846](#6846))

### Features

* **aws:** Add Elasticbeanstalk Application Tags ([#6915](#6915)) ([fd66b78](fd66b78))
* **aws:** Add missing descriptions ([#6847](#6847)) ([d62b50b](d62b50b))
* **aws:** Add RDS DB Proxies ([#6831](#6831)) ([8233160](8233160))
* **aws:** Remove more codegen ([#6853](#6853)) ([795e40d](795e40d))


### Bug Fixes

* **aws:** Add `db_engine_version_description` to `aws_rds_engine_versions` primary key ([#6851](#6851)) ([779be98](779be98))
* **aws:** Add `name` and `vendor_name` to `aws_wafv2_managed_rule_groups` primary key ([#6843](#6843)) ([d555ed5](d555ed5))
* **aws:** Add `region` to `aws_docdb_engine_versions` primary key ([#6846](#6846)) ([0f624ab](0f624ab))
* **aws:** Add `region` to `aws_glue_datacatalog_encryption_settings` primary key ([#6845](#6845)) ([9b8b5b1](9b8b5b1))
* **aws:** Add `region` to `aws_ram_resource_types` primary key ([#6850](#6850)) ([99eddd6](99eddd6))
* **aws:** Add region to `aws_backup_global_settings` primary key ([#6844](#6844)) ([397e02a](397e02a))
* **aws:** Remove redundant fields from `aws_lambda_runtimes` ([#6849](#6849)) ([cc5af56](cc5af56))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs to v1.19.0 ([#6813](#6813)) ([c623e0a](c623e0a))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ec2 to v1.78.0 ([#6814](#6814)) ([902bee0](902bee0))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ecrpublic to v1.15.0 ([#6815](#6815)) ([df72894](df72894))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/lambda to v1.28.0 ([#6816](#6816)) ([56fe84f](56fe84f))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/rds to v1.40.0 ([#6817](#6817)) ([6227bef](6227bef))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/resourcegroups to v1.14.0 ([#6818](#6818)) ([c343395](c343395))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/secretsmanager to v1.18.1 ([#6812](#6812)) ([99df2d9](99df2d9))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/shield to v1.18.0 ([#6819](#6819)) ([0f18621](0f18621))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/sns to v1.19.0 ([#6820](#6820)) ([95bbafd](95bbafd))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/sqs to v1.20.0 ([#6821](#6821)) ([02974bc](02974bc))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ssm to v1.35.0 ([#6822](#6822)) ([82250e0](82250e0))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ssoadmin to v1.16.0 ([#6823](#6823)) ([75412e5](75412e5))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/timestreamwrite to v1.15.0 ([#6824](#6824)) ([8912b57](8912b57))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/transfer to v1.28.0 ([#6825](#6825)) ([18f6ad7](18f6ad7))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/waf to v1.12.0 ([#6826](#6826)) ([0c8c0d3](0c8c0d3))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/wafregional to v1.13.1 ([#6827](#6827)) ([d3a03fc](d3a03fc))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/wafv2 to v1.24.1 ([#6828](#6828)) ([d24c78e](d24c78e))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/workspaces to v1.28.0 ([#6829](#6829)) ([8ce0af6](8ce0af6))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/xray to v1.16.0 ([#6830](#6830)) ([0d88a34](0d88a34))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.25.1 ([#6805](#6805)) ([9da0ce2](9da0ce2))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.26.0 ([#6839](#6839)) ([6ccda8d](6ccda8d))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.27.0 ([#6856](#6856)) ([545799b](545799b))
* Update endpoints ([#6798](#6798)) ([041040d](041040d))
* Update endpoints ([#6912](#6912)) ([bb77355](bb77355))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants