fix(aws): Add name and vendor_name to aws_wafv2_managed_rule_groups primary key (#6843)

disq · web-flow · commit d555ed5ad36c · 2023-01-17T18:53:59.000Z
Non breaking as `name` and `vendor_name` are both part of already existing resources.
diff --git a/plugins/source/aws/docs/tables/aws_wafv2_managed_rule_groups.md b/plugins/source/aws/docs/tables/aws_wafv2_managed_rule_groups.md
@@ -2,7 +2,7 @@
 
 https://docs.aws.amazon.com/waf/latest/APIReference/API_ManagedRuleGroupSummary.html
 
-The composite primary key for this table is (**account_id**, **region**, **scope**).
+The composite primary key for this table is (**account_id**, **region**, **scope**, **name**, **vendor_name**).
 
 ## Columns
 
@@ -17,6 +17,6 @@ The composite primary key for this table is (**account_id**, **region**, **scope
 |scope (PK)|String|
 |properties|JSON|
 |description|String|
-|name|String|
-|vendor_name|String|
+|name (PK)|String|
+|vendor_name (PK)|String|
 |versioning_supported|Bool|
diff --git a/plugins/source/aws/resources/services/wafv2/managed_rule_groups.go b/plugins/source/aws/resources/services/wafv2/managed_rule_groups.go
@@ -12,7 +12,7 @@ func ManagedRuleGroups() *schema.Table {
 		Name:        "aws_wafv2_managed_rule_groups",
 		Description: `https://docs.aws.amazon.com/waf/latest/APIReference/API_ManagedRuleGroupSummary.html`,
 		Resolver:    fetchWafv2ManagedRuleGroups,
-		Transform:   transformers.TransformWithStruct(&types.ManagedRuleGroupSummary{}),
+		Transform:   transformers.TransformWithStruct(&types.ManagedRuleGroupSummary{}, transformers.WithPrimaryKeys("Name", "VendorName")),
 		Multiplex:   client.ServiceAccountRegionScopeMultiplexer("waf-regional"),
 		Columns: []schema.Column{
 			{

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ func ManagedRuleGroups() *schema.Table {`
`12`	`12`	`Name: "aws_wafv2_managed_rule_groups",`
`13`	`13`	Description: `https://docs.aws.amazon.com/waf/latest/APIReference/API_ManagedRuleGroupSummary.html`,
`14`	`14`	`Resolver: fetchWafv2ManagedRuleGroups,`
`15`		`- Transform: transformers.TransformWithStruct(&types.ManagedRuleGroupSummary{}),`
	`15`	`+ Transform: transformers.TransformWithStruct(&types.ManagedRuleGroupSummary{}, transformers.WithPrimaryKeys("Name", "VendorName")),`
`16`	`16`	`Multiplex: client.ServiceAccountRegionScopeMultiplexer("waf-regional"),`
`17`	`17`	`Columns: []schema.Column{`
`18`	`18`	`{`