fix(aws)!: Add region to `aws_backup_global_settings` primary key by disq · Pull Request #6844 · cloudquery/cloudquery

disq · 2023-01-16T14:12:23Z

~~Few things I don't understand:~~

~~- How is it global when it's region based?~~
~~- If it's not region based, just asks for a region to query the same settings from, then how come we have it as a region multiplexed resource?~~

https://docs.aws.amazon.com/aws-backup/latest/devguide/API_DescribeGlobalSettings.html

github-actions · 2023-01-16T14:12:55Z

This PR has the following changes to source plugin(s) tables:

⚠️ BREAKING CHANGE: Table aws_backup_global_settings: column added with name region (PK) and type String

erezrokah · 2023-01-16T14:31:49Z

Please note this is a breaking change as region is missing on existing data

bbernays · 2023-01-17T13:00:30Z

Looking at the data it is only about account level functionalities, and because accounts are regionless resources this should also be global

disq · 2023-01-17T13:34:00Z

Looking at the data it is only about account level functionalities, and because accounts are regionless resources this should also be global

Updated to use AccountMultiplex

bbernays · 2023-01-17T14:04:08Z

I think we have to test the change in multiplexer out because there are only certain regions where you can make this call...

disq · 2023-01-17T14:30:02Z

I think we have to test the change in multiplexer out because there are only certain regions where you can make this call...

Updated to use a supported region... Could also save the region. Also, currently there's no way to force it to a specific region?

plugins/source/aws/client/multiplexers.go

bbernays · 2023-01-17T22:09:36Z

After discussing with @candiduslynx, the most simple and straight forward way of ensuring we get the data is to add the region as a PK, any other solutions would need extensive documentation to ensure edge cases around regional availability and IAM permissions are understood

This reverts commit 249225e.

This reverts commit 5b62154.

This reverts commit ce9882f.

disq · 2023-01-18T08:57:32Z

After discussing with @candiduslynx, the most simple and straight forward way of ensuring we get the data is to add the region as a PK, any other solutions would need extensive documentation to ensure edge cases around regional availability and IAM permissions are understood

Reverted last 3 commits to get it to where we want it.

🤖 I have created a release *beep* *boop* --- ## [12.0.0](plugins-source-aws-v11.0.1...plugins-source-aws-v12.0.0) (2023-01-18) ### ⚠ BREAKING CHANGES * **aws:** Add region to `aws_backup_global_settings` primary key ([#6844](#6844)) * **aws:** Remove redundant fields from `aws_lambda_runtimes` ([#6849](#6849)) * **aws:** Add `region` to `aws_docdb_engine_versions` primary key ([#6846](#6846)) ### Features * **aws:** Add Elasticbeanstalk Application Tags ([#6915](#6915)) ([fd66b78](fd66b78)) * **aws:** Add missing descriptions ([#6847](#6847)) ([d62b50b](d62b50b)) * **aws:** Add RDS DB Proxies ([#6831](#6831)) ([8233160](8233160)) * **aws:** Remove more codegen ([#6853](#6853)) ([795e40d](795e40d)) ### Bug Fixes * **aws:** Add `db_engine_version_description` to `aws_rds_engine_versions` primary key ([#6851](#6851)) ([779be98](779be98)) * **aws:** Add `name` and `vendor_name` to `aws_wafv2_managed_rule_groups` primary key ([#6843](#6843)) ([d555ed5](d555ed5)) * **aws:** Add `region` to `aws_docdb_engine_versions` primary key ([#6846](#6846)) ([0f624ab](0f624ab)) * **aws:** Add `region` to `aws_glue_datacatalog_encryption_settings` primary key ([#6845](#6845)) ([9b8b5b1](9b8b5b1)) * **aws:** Add `region` to `aws_ram_resource_types` primary key ([#6850](#6850)) ([99eddd6](99eddd6)) * **aws:** Add region to `aws_backup_global_settings` primary key ([#6844](#6844)) ([397e02a](397e02a)) * **aws:** Remove redundant fields from `aws_lambda_runtimes` ([#6849](#6849)) ([cc5af56](cc5af56)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs to v1.19.0 ([#6813](#6813)) ([c623e0a](c623e0a)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ec2 to v1.78.0 ([#6814](#6814)) ([902bee0](902bee0)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ecrpublic to v1.15.0 ([#6815](#6815)) ([df72894](df72894)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/lambda to v1.28.0 ([#6816](#6816)) ([56fe84f](56fe84f)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/rds to v1.40.0 ([#6817](#6817)) ([6227bef](6227bef)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/resourcegroups to v1.14.0 ([#6818](#6818)) ([c343395](c343395)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/secretsmanager to v1.18.1 ([#6812](#6812)) ([99df2d9](99df2d9)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/shield to v1.18.0 ([#6819](#6819)) ([0f18621](0f18621)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/sns to v1.19.0 ([#6820](#6820)) ([95bbafd](95bbafd)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/sqs to v1.20.0 ([#6821](#6821)) ([02974bc](02974bc)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ssm to v1.35.0 ([#6822](#6822)) ([82250e0](82250e0)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ssoadmin to v1.16.0 ([#6823](#6823)) ([75412e5](75412e5)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/timestreamwrite to v1.15.0 ([#6824](#6824)) ([8912b57](8912b57)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/transfer to v1.28.0 ([#6825](#6825)) ([18f6ad7](18f6ad7)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/waf to v1.12.0 ([#6826](#6826)) ([0c8c0d3](0c8c0d3)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/wafregional to v1.13.1 ([#6827](#6827)) ([d3a03fc](d3a03fc)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/wafv2 to v1.24.1 ([#6828](#6828)) ([d24c78e](d24c78e)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/workspaces to v1.28.0 ([#6829](#6829)) ([8ce0af6](8ce0af6)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/xray to v1.16.0 ([#6830](#6830)) ([0d88a34](0d88a34)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.25.1 ([#6805](#6805)) ([9da0ce2](9da0ce2)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.26.0 ([#6839](#6839)) ([6ccda8d](6ccda8d)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.27.0 ([#6856](#6856)) ([545799b](545799b)) * Update endpoints ([#6798](#6798)) ([041040d](041040d)) * Update endpoints ([#6912](#6912)) ([bb77355](bb77355)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

fix(aws): Add region to aws_backup_global_settings

6f2efc0

disq requested a review from candiduslynx January 16, 2023 14:12

disq requested review from hermanschaaf and yevgenypats as code owners January 16, 2023 14:12

cq-bot added the aws label Jan 16, 2023

candiduslynx approved these changes Jan 16, 2023

View reviewed changes

candiduslynx mentioned this pull request Jan 16, 2023

Several AWS resources have duplicates #6837

Closed

7 tasks

hermanschaaf approved these changes Jan 16, 2023

View reviewed changes

hermanschaaf changed the title ~~fix(aws): Add region to aws_backup_global_settings~~ fix(aws)!: Add region to aws_backup_global_settings Jan 16, 2023

candiduslynx changed the title ~~fix(aws)!: Add region to aws_backup_global_settings~~ fix(aws)!: Add region to aws_backup_global_settings primary key Jan 16, 2023

use accountmultiplex

ce9882f

disq changed the title ~~fix(aws)!: Add region to aws_backup_global_settings primary key~~ fix(aws): Use account multiplexer for aws_backup_global_settings Jan 17, 2023

candiduslynx approved these changes Jan 17, 2023

View reviewed changes

Use a single region from the service list

5b62154

gen-docs

249225e

bbernays reviewed Jan 17, 2023

View reviewed changes

plugins/source/aws/client/multiplexers.go Outdated Show resolved Hide resolved

disq added 3 commits January 18, 2023 08:55

Revert "gen-docs"

bbc5b42

This reverts commit 249225e.

Revert "Use a single region from the service list"

8656034

This reverts commit 5b62154.

Revert "use accountmultiplex"

0c2a90a

This reverts commit ce9882f.

disq changed the title ~~fix(aws): Use account multiplexer for aws_backup_global_settings~~ fix(aws)!: Use account multiplexer for aws_backup_global_settings Jan 18, 2023

candiduslynx approved these changes Jan 18, 2023

View reviewed changes

candiduslynx added the automerge Automatically merge once required checks pass label Jan 18, 2023

candiduslynx linked an issue Jan 18, 2023 that may be closed by this pull request

Several AWS resources have duplicates #6837

Closed

7 tasks

Merge branch 'main' into fix/aws_backup_global_settings

b0b55a2

candiduslynx changed the title ~~fix(aws)!: Use account multiplexer for aws_backup_global_settings~~ fix(aws)!: Add region to aws_backup_global_settings primary key Jan 18, 2023

vercel bot deployed to Preview January 18, 2023 09:04 View deployment

Merge branch 'main' into fix/aws_backup_global_settings

6d56437

vercel bot deployed to Preview January 18, 2023 09:25 View deployment

kodiakhq bot merged commit 397e02a into cloudquery:main Jan 18, 2023

cq-bot mentioned this pull request Jan 18, 2023

chore(main): Release plugins-source-aws v12.0.0 #6799

Merged

disq deleted the fix/aws_backup_global_settings branch January 18, 2023 09:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(aws)!: Add region to `aws_backup_global_settings` primary key#6844

fix(aws)!: Add region to `aws_backup_global_settings` primary key#6844
kodiakhq[bot] merged 9 commits intocloudquery:mainfrom
disq:fix/aws_backup_global_settings

disq commented Jan 16, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Jan 16, 2023

Uh oh!

erezrokah commented Jan 16, 2023

Uh oh!

bbernays commented Jan 17, 2023

Uh oh!

disq commented Jan 17, 2023

Uh oh!

bbernays commented Jan 17, 2023

Uh oh!

disq commented Jan 17, 2023

Uh oh!

Uh oh!

bbernays commented Jan 17, 2023

Uh oh!

disq commented Jan 18, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

disq commented Jan 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 16, 2023

This PR has the following changes to source plugin(s) tables:

Uh oh!

erezrokah commented Jan 16, 2023

Uh oh!

bbernays commented Jan 17, 2023

Uh oh!

disq commented Jan 17, 2023

Uh oh!

bbernays commented Jan 17, 2023

Uh oh!

disq commented Jan 17, 2023

Uh oh!

Uh oh!

bbernays commented Jan 17, 2023

Uh oh!

disq commented Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

disq commented Jan 16, 2023 •

edited

Loading

disq commented Jan 18, 2023 •

edited

Loading