Skip to content

fix(aws): Add region to aws_ram_resource_types primary key#6850

Merged
kodiakhq[bot] merged 2 commits intomainfrom
fix/aws/pk/ram-resource-types
Jan 17, 2023
Merged

fix(aws): Add region to aws_ram_resource_types primary key#6850
kodiakhq[bot] merged 2 commits intomainfrom
fix/aws/pk/ram-resource-types

Conversation

@candiduslynx
Copy link
Copy Markdown
Contributor

@candiduslynx candiduslynx commented Jan 16, 2023 •
edited by hermanschaaf
Loading

non-breaking as the field was already there

@cq-bot cq-bot added the aws label Jan 16, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 16, 2023

This PR has the following changes to source plugin(s) tables:

  • Table aws_ram_resource_types: column order changed for resource_region_scope
  • Table aws_ram_resource_types: column order changed for service_name
  • Table aws_ram_resource_types: primary key constraint added to column region

@candiduslynx candiduslynx mentioned this pull request Jan 16, 2023
Closed
7 tasks
bbernays
bbernays requested changes Jan 17, 2023
View reviewed changes
@candiduslynx candiduslynx force-pushed the fix/aws/pk/ram-resource-types branch from 0d1a15e to afebd93 Compare January 17, 2023 15:37
@candiduslynx candiduslynx requested a review from bbernays January 17, 2023 15:42
@candiduslynx
Copy link
Copy Markdown
Contributor Author

candiduslynx commented Jan 17, 2023

@bbernays I believe that the global vs regional is covered in this doc.
Judging by the text, the resource type can be either regional or global, but not both.

@candiduslynx candiduslynx force-pushed the fix/aws/pk/ram-resource-types branch from afebd93 to ef7be8a Compare January 17, 2023 18:09
@bbernays
Copy link
Copy Markdown
Collaborator

bbernays commented Jan 17, 2023

@candiduslynx So based on that documentation, the region should be nil/null for global resources, while our implementation will always put a region because it is defined as being the region where the ListResourceTypes call was made

@candiduslynx
Copy link
Copy Markdown
Contributor Author

candiduslynx commented Jan 17, 2023

After a deeper discussion with @bbernays decided to only add region for now, as it's currently correct. However, that might change in the future if AWS wishes so.

@candiduslynx candiduslynx added the automerge Automatically merge once required checks pass label Jan 17, 2023
@kodiakhq kodiakhq bot merged commit 99eddd6 into main Jan 17, 2023
@kodiakhq kodiakhq bot deleted the fix/aws/pk/ram-resource-types branch January 17, 2023 22:20
@cq-bot cq-bot mentioned this pull request Jan 17, 2023
Merged
@candiduslynx candiduslynx linked an issue Jan 18, 2023 that may be closed by this pull request
Several AWS resources have duplicates #6837
Closed
7 tasks
kodiakhq bot pushed a commit that referenced this pull request Jan 18, 2023
@cq-bot
chore(main): Release plugins-source-aws v12.0.0 (#6799)
7022217 
🤖 I have created a release *beep* *boop*
---


## [12.0.0](plugins-source-aws-v11.0.1...plugins-source-aws-v12.0.0) (2023-01-18)


### ⚠ BREAKING CHANGES

* **aws:** Add region to `aws_backup_global_settings` primary key ([#6844](#6844))
* **aws:** Remove redundant fields from `aws_lambda_runtimes` ([#6849](#6849))
* **aws:** Add `region` to `aws_docdb_engine_versions` primary key ([#6846](#6846))

### Features

* **aws:** Add Elasticbeanstalk Application Tags ([#6915](#6915)) ([fd66b78](fd66b78))
* **aws:** Add missing descriptions ([#6847](#6847)) ([d62b50b](d62b50b))
* **aws:** Add RDS DB Proxies ([#6831](#6831)) ([8233160](8233160))
* **aws:** Remove more codegen ([#6853](#6853)) ([795e40d](795e40d))


### Bug Fixes

* **aws:** Add `db_engine_version_description` to `aws_rds_engine_versions` primary key ([#6851](#6851)) ([779be98](779be98))
* **aws:** Add `name` and `vendor_name` to `aws_wafv2_managed_rule_groups` primary key ([#6843](#6843)) ([d555ed5](d555ed5))
* **aws:** Add `region` to `aws_docdb_engine_versions` primary key ([#6846](#6846)) ([0f624ab](0f624ab))
* **aws:** Add `region` to `aws_glue_datacatalog_encryption_settings` primary key ([#6845](#6845)) ([9b8b5b1](9b8b5b1))
* **aws:** Add `region` to `aws_ram_resource_types` primary key ([#6850](#6850)) ([99eddd6](99eddd6))
* **aws:** Add region to `aws_backup_global_settings` primary key ([#6844](#6844)) ([397e02a](397e02a))
* **aws:** Remove redundant fields from `aws_lambda_runtimes` ([#6849](#6849)) ([cc5af56](cc5af56))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs to v1.19.0 ([#6813](#6813)) ([c623e0a](c623e0a))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ec2 to v1.78.0 ([#6814](#6814)) ([902bee0](902bee0))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ecrpublic to v1.15.0 ([#6815](#6815)) ([df72894](df72894))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/lambda to v1.28.0 ([#6816](#6816)) ([56fe84f](56fe84f))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/rds to v1.40.0 ([#6817](#6817)) ([6227bef](6227bef))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/resourcegroups to v1.14.0 ([#6818](#6818)) ([c343395](c343395))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/secretsmanager to v1.18.1 ([#6812](#6812)) ([99df2d9](99df2d9))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/shield to v1.18.0 ([#6819](#6819)) ([0f18621](0f18621))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/sns to v1.19.0 ([#6820](#6820)) ([95bbafd](95bbafd))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/sqs to v1.20.0 ([#6821](#6821)) ([02974bc](02974bc))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ssm to v1.35.0 ([#6822](#6822)) ([82250e0](82250e0))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ssoadmin to v1.16.0 ([#6823](#6823)) ([75412e5](75412e5))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/timestreamwrite to v1.15.0 ([#6824](#6824)) ([8912b57](8912b57))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/transfer to v1.28.0 ([#6825](#6825)) ([18f6ad7](18f6ad7))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/waf to v1.12.0 ([#6826](#6826)) ([0c8c0d3](0c8c0d3))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/wafregional to v1.13.1 ([#6827](#6827)) ([d3a03fc](d3a03fc))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/wafv2 to v1.24.1 ([#6828](#6828)) ([d24c78e](d24c78e))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/workspaces to v1.28.0 ([#6829](#6829)) ([8ce0af6](8ce0af6))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/xray to v1.16.0 ([#6830](#6830)) ([0d88a34](0d88a34))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.25.1 ([#6805](#6805)) ([9da0ce2](9da0ce2))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.26.0 ([#6839](#6839)) ([6ccda8d](6ccda8d))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.27.0 ([#6856](#6856)) ([545799b](545799b))
* Update endpoints ([#6798](#6798)) ([041040d](041040d))
* Update endpoints ([#6912](#6912)) ([bb77355](bb77355))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbernays bbernays bbernays approved these changes

@yevgenypats yevgenypats Awaiting requested review from yevgenypats

+1 more reviewer

@hermanschaaf hermanschaaf hermanschaaf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Several AWS resources have duplicates

4 participants

@candiduslynx @bbernays @hermanschaaf @cq-bot