Merged
Conversation
youngnick
approved these changes
Feb 25, 2026
julianwiedmann
requested changes
Feb 25, 2026
liyihuang
approved these changes
Feb 26, 2026
79496fa to
8650fd5
Compare
Member
Author
|
/test |
8650fd5 to
e8989ad
Compare
Member
Author
|
/test |
|
Commit d123ec6 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Member
Author
|
/ci-e2e-upgrade |
Member
Author
|
/test |
aanm
approved these changes
Mar 2, 2026
nebril
approved these changes
Mar 2, 2026
[ upstream commit c0d2d72 ] [ backporter's note: Remove the matrix generation code that doesn't exist in this branch ] Some e2e configs specify a different encryption algorithm (cbc-aes-sha256). Have the e2e-upgrade workflow respect this. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
[ upstream commit 038d3ee ] The newly introduced loadbalancer healthserver script test that tests the health for services with proxy redirection sometimes fails with the following error. ``` scripttest.go:72: (command "* cmp healthserver-proxy.expected healthserver.after" failed, retrying in 500ms...) diff healthserver-proxy.expected healthserver.after --- healthserver-proxy.expected +++ healthserver.after Content-Type=application/json Date=<omitted> X-Content-Type-Options=nosniff -X-Load-Balancing-Endpoint-Weight=1 +X-Load-Balancing-Endpoint-Weight=3 --- -{"service":{"namespace":"test","name":"echo"},"localEndpoints":1} +{"service":{"namespace":"test","name":"echo"},"localEndpoints":3} ``` See https://github.com/cilium/cilium/actions/runs/21952595101/job/63407305531 Also reproduced locally when executing the test in a loop. It seems that asynchronous (k8s) event processing can lead to situations where the proxy redirection port (set with `svc/set-proxy-redirect` test helper) is reset. Even the retry to fetch and compare will always see the same outdated data. Therefore it seems to be safer to include the call to `svc/set-proxy-redirect test/echo 1000` into the same hive script test section so that it gets retried too in case of a failure (`* `) prefix. See https://docs.cilium.io/en/stable/contributing/development/hive/#command-reference for more info. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com> Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
[ upstream commit d259c76 ] Signed-off-by: André Martins <andre@cilium.io> Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
d123ec6 to
d3ae6b9
Compare
Contributor
|
/test |
[ upstream commit 167899c ] [ backporter's note: The signature of toHTTPRoutes and toGRPCRoutes are different from the upstream. Adjust it. Also, the list of the test cases are diverged from the upstream. Take this branch's list and add "cert manager gateway" case. ] This commit fixes a bug that prevented cert-manager from working correctly in the Gateway API reconciler. When checking hostnames to see if they were isolated from other Listeners on the same Gateway, Cilium did not distinguish between Listeners of different Protocols. This meant that when a HTTP and HTTPS listener had the same or overlapping hostnames, then the HTTP config would not be generated. The fix was to keep track of the hostnames by Protocol, and only check the ones of the _same_ protocol, which was the correct behavior the whole time. This adds a new test to the model ingestion to catch this specific case as well. Updates #36750 Updates #44123 Signed-off-by: Nick Young <nick@isovalent.com>
d3ae6b9 to
d3f666b
Compare
Member
Author
|
/test |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ip get -l reserved:host#44443 (@aanm)backport/authorsince it caused a lot of failure in the CI (example). We didn't see this in v1.19, so something v1.18-specific logic involved to the failure. Please take a look @liyihuang.Once this PR is merged, a GitHub action will update the labels of these PRs: