loadbalancer/healthserver: stabilize proxy-redirect test#44323
Merged
dylandreimerink merged 1 commit intocilium:mainfrom Feb 19, 2026
Merged
Conversation
The newly introduced loadbalancer healthserver script
test that tests the health for services with proxy redirection
sometimes fails with the following error.
```
scripttest.go:72: (command "* cmp healthserver-proxy.expected healthserver.after" failed, retrying in 500ms...)
diff healthserver-proxy.expected healthserver.after
--- healthserver-proxy.expected
+++ healthserver.after
Content-Type=application/json
Date=<omitted>
X-Content-Type-Options=nosniff
-X-Load-Balancing-Endpoint-Weight=1
+X-Load-Balancing-Endpoint-Weight=3
---
-{"service":{"namespace":"test","name":"echo"},"localEndpoints":1}
+{"service":{"namespace":"test","name":"echo"},"localEndpoints":3}
```
See https://github.com/cilium/cilium/actions/runs/21952595101/job/63407305531
Also reproduced locally when executing the test in a loop.
It seems that asynchronous (k8s) event processing can lead
to situations where the proxy redirection port (set with
`svc/set-proxy-redirect` test helper) is reset.
Even the retry to fetch and compare will always see the same
outdated data.
Therefore it seems to be safer to include the call to
`svc/set-proxy-redirect test/echo 1000` into the same
hive script test section so that it gets retried too
in case of a failure (`* `) prefix.
See https://docs.cilium.io/en/stable/contributing/development/hive/#command-reference
for more info.
Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
8e96168 to
10e94ad
Compare
Member
Author
|
/test (10 runs of |
dylandreimerink
approved these changes
Feb 19, 2026
21 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newly introduced loadbalancer healthserver script test that tests the health for services with proxy redirection sometimes fails with the following error.
See https://github.com/cilium/cilium/actions/runs/21952595101/job/63407305531
I was also able to reproduce it once locally when executing the test in a loop.
It seems that asynchronous (k8s) event processing can lead to situations where the proxy redirection port (set with
svc/set-proxy-redirecttest helper) is reset.Even the retry to fetch and compare will always see the same outdated data.
Therefore it seems to be safer to include the call to
svc/set-proxy-redirect test/echo 1000into the same hive script test section so that it gets retried too in case of a failure (*) prefix.See https://docs.cilium.io/en/stable/contributing/development/hive/#command-reference for more info.
Fixes: #44286 (introduced the test while fixing an issue)
Fixes: #44414 🙏