loadbalancer/healthserver: refresh ProxyRedirect per request#44286
Merged
mhofstetter merged 1 commit intocilium:mainfrom Feb 11, 2026
Merged
Conversation
b187162 to
7f3d8f1
Compare
This commit fixes stale ProxyRedirect reads in the health server by reloading Service state from the services table on each request. This prevents incorrect local endpoint counts when Envoy redirect state changes after the listener is created (which is the case). Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
7f3d8f1 to
006a22c
Compare
Member
Author
|
/test |
joamaki
approved these changes
Feb 11, 2026
Contributor
joamaki
left a comment
There was a problem hiding this comment.
Ouch. Good catch. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes stale ProxyRedirect reads in the health server by reloading Service state from the services table on each request. This prevents incorrect local endpoint counts when Envoy redirect state changes after the listener is created (which is the case).
Note: Seems like this is related to a recent comment (3 weeks ago) on another issue that mentions that
externalTrafficPolicy=Localseems to be broken (again) for Cilium Ingress & Gateway API: #33547 (comment)