gh: e2e-upgrade: don't hardcode IPsec encryption algorithm#44381
Merged
julianwiedmann merged 1 commit intomainfrom Feb 17, 2026
Merged
gh: e2e-upgrade: don't hardcode IPsec encryption algorithm#44381julianwiedmann merged 1 commit intomainfrom
julianwiedmann merged 1 commit intomainfrom
Conversation
Member
Author
|
/test |
1 similar comment
Member
Author
|
/test |
Some e2e configs specify a different encryption algorithm (cbc-aes-sha256). Have the e2e-upgrade workflow respect this. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
67f06ca to
8d4ea97
Compare
Member
Author
|
/test |
Member
Author
|
No failures in the IPsec configs (https://github.com/cilium/cilium/actions/runs/22059550432, https://github.com/cilium/cilium/actions/runs/22059551693/job/63736930942), dropping the test commit. |
8d4ea97 to
21fc427
Compare
Member
Author
|
/test |
smagnani96
approved these changes
Feb 16, 2026
Contributor
smagnani96
left a comment
There was a problem hiding this comment.
Nice catch. I see we've hardcoded in other workflows (eks, gke, etc.), but we're not testing rotation there.
Thanks!
Member
Author
Yeah there it's more about adding additional Cilium configs (if we ever care). But for |
viktor-kurchenko
approved these changes
Feb 17, 2026
21 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some e2e configs specify a different encryption algorithm (cbc-aes-sha256). Have the e2e-upgrade workflow respect this.