endpoint/bpf: remove change empty conditon for updateEnvoy#44462
Merged
squeed merged 1 commit intocilium:mainfrom Feb 23, 2026
Merged
endpoint/bpf: remove change empty conditon for updateEnvoy#44462squeed merged 1 commit intocilium:mainfrom
squeed merged 1 commit intocilium:mainfrom
Conversation
ed02ce1 to
1b85244
Compare
This commit removes the !changes.Empty() condition to avoid the bug when the bpf map is no change but we still need to update the envoy network policy. When there is SNI network policy with FQDN network policy, we will redirect egress all traffic to the envoy. The identity could change with wildcard FQDN policy and bpf map will keep the same. that will cause the enovy network policy not getting updated. For example,we could have the following identities in the beginning 1677721 fqdn:sts.*.amazonaws.com reserved:world 16777220 fqdn:*.amazonaws.com reserved:world When the DNS resolves the IP for sts.*.amazonaws.com, we will generate the new identity 16777223 fqdn:*.*.amazonaws.com fqdn:sts.*.amazonaws.com reserved:world If we have the SNI network policy for the pod, that will make the bpf map look like the following. root@kind-worker8:/home/cilium# cilium bpf policy get 2782 POLICY DIRECTION LABELS (source:key[=value]) PORT/PROTO PROXY PORT AUTH TYPE BYTES PACKETS PREFIX LEVEL Allow Ingress ANY ANY NONE disabled 0 0 0 0 Allow Ingress reserved:host ANY NONE disabled 0 0 0 0 Allow Egress ANY 443/TCP 13379 disabled 5904 33 24 0 With the current check logic, there is no change to the map. Then we will skip updating the envoy network policy causing envoy holding the stale identity and block the traffic. Signed-off-by: Liyi Huang <liyi.huang@isovalent.com>
1b85244 to
727024c
Compare
Contributor
Author
|
/test |
Contributor
|
I'm not sure I understand the exact bug here. From the commit message, it seems to be something like
Do you know why |
Contributor
|
The change looks good, I just want to understand the issue first. |
squeed
approved these changes
Feb 23, 2026
21 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see the commit message