gateway-api: Fix hostname bug breaking cert-manager#44492
Merged
joestringer merged 1 commit intocilium:mainfrom Feb 24, 2026
Merged
gateway-api: Fix hostname bug breaking cert-manager#44492joestringer merged 1 commit intocilium:mainfrom
joestringer merged 1 commit intocilium:mainfrom
Conversation
This was referenced Feb 23, 2026
sayboras
reviewed
Feb 23, 2026
185b0ce to
d98af7c
Compare
sayboras
approved these changes
Feb 23, 2026
Member
sayboras
left a comment
There was a problem hiding this comment.
ah nice, thanks for fixing this bug 💯
This commit fixes a bug that prevented cert-manager from working correctly in the Gateway API reconciler. When checking hostnames to see if they were isolated from other Listeners on the same Gateway, Cilium did not distinguish between Listeners of different Protocols. This meant that when a HTTP and HTTPS listener had the same or overlapping hostnames, then the HTTP config would not be generated. The fix was to keep track of the hostnames by Protocol, and only check the ones of the _same_ protocol, which was the correct behavior the whole time. This adds a new test to the model ingestion to catch this specific case as well. Updates cilium#36750 Updates cilium#44123 Signed-off-by: Nick Young <nick@isovalent.com>
d98af7c to
2a82046
Compare
Contributor
Author
|
/test |
1 similar comment
Contributor
Author
|
/test |
21 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug that prevented cert-manager from working correctly in the Gateway API reconciler.
When checking hostnames to see if they were isolated from other Listeners on the same Gateway, Cilium did not distinguish between Listeners of different Protocols.
This meant that when a HTTP and HTTPS listener had the same or overlapping hostnames, then the HTTP config would not be generated.
The fix was to keep track of the hostnames by Protocol, and only check the ones of the same protocol, which was the correct behavior the whole time.
This adds a new test to the model ingestion to catch this specific case as well.
Updates #36750
Updates #44123