Fixes for more cppcheck issues by dalgaaf · Pull Request #101 · ceph/ceph

dalgaaf · 2013-03-12T15:11:44Z

These commits address issues like:

use static_cast instead of C-Style cast
remove unused variables
perform initialization of variables in initialization list of constructor
use %u to format unsigned in snprintf()
remove never executed statements after return
reduce scope of some variables
catch exception by reference
return 'const string' instead of 'const char *' to avoid potentially dangerous usage of std::string::c_str on return from a function
prefer prefix ++/--operator for non-primitive types

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

…list Perform initialization of IntentLogNameFilter:prefix in initialization list instead of constructor body. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

Don't compare unsigned maxfilelen against less than zero. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

Use ctx->ret() instead of bl.length() as return value. The length of bl can be checked by the caller, return status instead as already done in the other functions. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

Return a string instead of 'char *' to avoid usage of std::string:c_str() to return a 'char *' from get_state_name() in mon/Monitor.h. Related warning from cppcheck: [src/mon/Monitor.h:172]: (error) Dangerous usage of c_str(). The value returned by c_str() is invalid after this call. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

Prefer prefix ++operator for non-primitive types like iterators for performance reasons. Prefix ++/-- operators avoid creating a temporary copy. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

liewegas · 2013-03-12T15:17:45Z

src/mds/SessionMap.h

I think these methods are marginally more efficient if they stay as const char *. Returning a const string is implicitly constructing a string object in memory, vs just returning a pointer to const text. In most cases the caller doesn't need the std::string.

I changed it to return a string instead of char* due to usage of std::string::c_str() to return from get_state_name() in Monitor.h.

The problem with c_str() is that the result gets (may) invalid after the related string object gets destroyed or out of scope (which should be true on return). So you may get garbage in this case.

Oh, I see. Yeah, that function should definitely be changed. The others that are just switches returning literal strings should stay const char *, though.

Okay ... I will submit another pull request to fix only the issue in Monitor.h

liewegas · 2013-03-12T15:22:37Z

Everything looks good, except for the fsx and get_state_name() patches. Care to resubmit with those ones dropped?

Fixes for more cppcheck issues (v2 of #101) Reviewed-by: Sage Weil <sage@inktank.com>

Wip 7810

…v2-rename-block_pool_to-rbd mgr/dashboard_v2: Renamed `block_pool` controller to `rbd`

* Fix for CORTX-28869:Unable to create IAM user with email * Enable create user for same UID under different Tenant with motr as backend. (ceph#90) Signed-off-by: Diwakar92 <diwakar.kumar@seagate.com> Co-authored-by: kupranay <66459168+kupranay@users.noreply.github.com> * rgw_sal_motr: [CORTX-28055] Support custom & multiple access/secret keys (ceph#93) * rgw_sal_motr: [CORTX-28055] Support custom & multiple access/secret keys Added support for multple key creation for a user which can be either custom or auto generated. Signed-off-by: Jeet Jain <jeet.jain@seagate.com> * rgw_sal_motr: [EOS-27516] Handling object overwrite during put-object (ceph#89) * rgw_sal_motr: [EOS-27516] handling object overwrite Deleting existing object data if same object is uploaded again to avoid object leak. Signed-off-by: saurabh jain <saurabh.jain2@seagate.com> * rgw_sal_motr: [EOS-27516] Handle parallel upload During parallel object upload, there are chances of object leak, which can be handled by making use of GC. Since GC is not being use for motr as of now, adding a TODO for the same. Signed-off-by: saurabh jain <saurabh.jain@seagate.com> Co-authored-by: kupranay <66459168+kupranay@users.noreply.github.com> * Rebase (ceph#88) Signed-off-by: Parayya Vastrad <parayya.vastrad@seagate.com> * merge conflicts * merge conflicts * Review comments addressed * Review comments addressed Co-authored-by: root <root@ssc-vm-g4-rhev4-0716.colo.seagate.com> Co-authored-by: Diwakar92 <96409310+Diwakar92@users.noreply.github.com> Co-authored-by: kupranay <66459168+kupranay@users.noreply.github.com> Co-authored-by: Jeet Jain <jeet.jain@seagate.com> Co-authored-by: Saurabh Jain <91066893+sjain09@users.noreply.github.com> Co-authored-by: Parayya Vastrad <56255712+vastradparayya@users.noreply.github.com>

User email index is not present. Created user index and add user email entry in the email index in it. Signed-off-by: Sanal Kaarthikeyan <sanal.kaarthikeyan@seagate.com>

Support not between operator expression [NOT] between expression AND expression Signed-off-by: Albin Antony <aantony@redhat.com>

dalgaaf added 30 commits March 12, 2013 10:01

rgw/rgw_rados.cc: use static_cast instead of C-Style cast

b7f35db

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

rgw/rgw_rados.cc: remove unused variables

f4822f9

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

rgw/rgw_rados.cc: perform initialization of prefix in initialization …

ae292f7

…list Perform initialization of IntentLogNameFilter:prefix in initialization list instead of constructor body. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

rgw/rgw_rest_s3.cc: remove unused variables

d7e2943

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

rgw/rgw_rest_usage.cc: remove unused variables

782154c

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

rgw/rgw_user.cc: remove unused variables

df64bc4

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

rgw/rgw_xml.cc: use static_cast instead of C-Style cast

75c802f

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

test_keyvaluedb_iterators.cc: remove unused variable

941a4bb

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

test_object_map.cc: use %u to format unsigned in snprintf()

f13cbd1

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

bench/dumb_backend.h: remove never executed delete statement

ddfa39d

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

test/encoding/ceph_dencoder.cc: use static_cast instead of C-Style cast

73e1690

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

test/librados/aio.cc: use static_cast instead of C-Style cast

0c2f9b7

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

test/librbd/fsx.c: reduce scope of some variables

d33ff52

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

test/librbd/fsx.c: don't compare maxfilelen against less than zero

b78631f

Don't compare unsigned maxfilelen against less than zero. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

test/librbd/fsx.c: reduce scope of 'res' in __aio_rw()

0a9a394

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

test_mon_workloadgen.cc: remove unused variables

2f045e6

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

test/omap_bench.cc: remove unused variables

4236a04

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

test/osd/Object.cc: catch exception by reference

54d6341

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

test/osd/RadosModel.h: remove unused variables

6011268

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

test/system/st_rados_list_objects.cc: remove not needed statement

3149d0f

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

test/test_filejournal.cc: use %u to format unsigned in sprintf()

2b39529

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

tools/rest_bench.cc: remove unused variable

b5857c6

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

tools/rest_bench.cc: return ctx->ret() instead of bl.length()

e17b462

Use ctx->ret() instead of bl.length() as return value. The length of bl can be checked by the caller, return status instead as already done in the other functions. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

auth/Auth.h: prefer prefix ++operator for non-primitive types

408fe61

Prefer prefix ++operator for non-primitive types like iterators for performance reasons. Prefix ++/-- operators avoid creating a temporary copy. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

CephxKeyServer.h: prefer prefix ++operator for iterators

da5e8f0

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

SyntheticClient.h: prefer prefix ++operator for iterators

73ca88a

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

client/Inode.cc: prefer prefix ++operator for iterators

bf2cb98

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

cls/rgw/cls_rgw.cc: prefer prefix --operator for iterators

d600573

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

client/hadoop/CephFSInterface.cc: prefer prefix ++operator for iterators

1f52c89

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

liewegas reviewed Mar 12, 2013
View reviewed changes

liewegas closed this Mar 12, 2013

dalgaaf mentioned this pull request Mar 12, 2013

Fixes for more cppcheck issues (v2 of #101) #102

Merged

liewegas added a commit that referenced this pull request Mar 12, 2013

Merge pull request #102 from dalgaaf/wip-da-sca-style-4-v2

34f1984

Fixes for more cppcheck issues (v2 of #101) Reviewed-by: Sage Weil <sage@inktank.com>

liewegas pushed a commit that referenced this pull request Dec 14, 2016

Merge pull request #101 from ceph/wip-7810

322e249

Wip 7810

ricardoasmarques pushed a commit to ricardoasmarques/ceph that referenced this pull request Feb 16, 2018

Merge pull request ceph#101 from sebastian-philipp/wip-mgr-dashboard_…

1a6ee20

…v2-rename-block_pool_to-rbd mgr/dashboard_v2: Renamed `block_pool` controller to `rbd`

galsalomon66 referenced this pull request in galsalomon66/ceph Sep 17, 2022

s3select: not between operator (#101)

3a65da4

Support not between operator expression [NOT] between expression AND expression Signed-off-by: Albin Antony <aantony@redhat.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes for more cppcheck issues#101

Fixes for more cppcheck issues#101
dalgaaf wants to merge 30 commits intoceph:masterfrom
dalgaaf:wip-da-sca-style-4

dalgaaf commented Mar 12, 2013

Uh oh!

liewegas Mar 12, 2013

Uh oh!

dalgaaf Mar 12, 2013

Uh oh!

liewegas Mar 12, 2013

Uh oh!

dalgaaf Mar 12, 2013

Uh oh!

liewegas commented Mar 12, 2013

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

dalgaaf commented Mar 12, 2013

Uh oh!

liewegas Mar 12, 2013

Choose a reason for hiding this comment

Uh oh!

dalgaaf Mar 12, 2013

Choose a reason for hiding this comment

Uh oh!

liewegas Mar 12, 2013

Choose a reason for hiding this comment

Uh oh!

dalgaaf Mar 12, 2013

Choose a reason for hiding this comment

Uh oh!

liewegas commented Mar 12, 2013

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants