Avoid sending a success response when an error occurs.#93
Merged
yehudasa merged 1 commit intoceph:masterfrom Mar 8, 2013
Merged
Avoid sending a success response when an error occurs.#93yehudasa merged 1 commit intoceph:masterfrom
yehudasa merged 1 commit intoceph:masterfrom
Conversation
Functions called from RGWGetObj_ObjStore_S3::send_response_data may change the value of the non-local variable 'ret'. But the response relies on a local 'req_state' which copies ret at the start of the function. Right now none of the called functions actually changes ret so the problem doesn't trigger, but to avoid future breakage it is safer to not rely on the (early) copy of the ret variable. Signed-off-by: Jan Harkes <jaharkes@cs.cmu.edu>
yehudasa
added a commit
that referenced
this pull request
Mar 8, 2013
Avoid sending a success response when an error occurs. Reviewed-by: Yehuda Sadeh <yehuda@inktank.com>
liewegas
added a commit
to liewegas/ceph
that referenced
this pull request
Nov 18, 2016
rgw: s/idle_timeout/default_idle_timeout/
rjfd
pushed a commit
to rjfd/ceph
that referenced
this pull request
Feb 14, 2018
mgr/dashboard_v2: add node as a local dependency
liewegas
pushed a commit
to liewegas/ceph
that referenced
this pull request
Nov 5, 2021
Developers roadmap layout
andriytk
pushed a commit
to andriytk/cortx-rgw
that referenced
this pull request
Mar 3, 2022
…eys (ceph#93) * rgw_sal_motr: [CORTX-28055] Support custom & multiple access/secret keys Added support for multple key creation for a user which can be either custom or auto generated. Signed-off-by: Jeet Jain <jeet.jain@seagate.com>
andriytk
pushed a commit
to andriytk/cortx-rgw
that referenced
this pull request
Mar 3, 2022
* Fix for CORTX-28869:Unable to create IAM user with email * Enable create user for same UID under different Tenant with motr as backend. (ceph#90) Signed-off-by: Diwakar92 <diwakar.kumar@seagate.com> Co-authored-by: kupranay <66459168+kupranay@users.noreply.github.com> * rgw_sal_motr: [CORTX-28055] Support custom & multiple access/secret keys (ceph#93) * rgw_sal_motr: [CORTX-28055] Support custom & multiple access/secret keys Added support for multple key creation for a user which can be either custom or auto generated. Signed-off-by: Jeet Jain <jeet.jain@seagate.com> * rgw_sal_motr: [EOS-27516] Handling object overwrite during put-object (ceph#89) * rgw_sal_motr: [EOS-27516] handling object overwrite Deleting existing object data if same object is uploaded again to avoid object leak. Signed-off-by: saurabh jain <saurabh.jain2@seagate.com> * rgw_sal_motr: [EOS-27516] Handle parallel upload During parallel object upload, there are chances of object leak, which can be handled by making use of GC. Since GC is not being use for motr as of now, adding a TODO for the same. Signed-off-by: saurabh jain <saurabh.jain@seagate.com> Co-authored-by: kupranay <66459168+kupranay@users.noreply.github.com> * Rebase (ceph#88) Signed-off-by: Parayya Vastrad <parayya.vastrad@seagate.com> * merge conflicts * merge conflicts * Review comments addressed * Review comments addressed Co-authored-by: root <root@ssc-vm-g4-rhev4-0716.colo.seagate.com> Co-authored-by: Diwakar92 <96409310+Diwakar92@users.noreply.github.com> Co-authored-by: kupranay <66459168+kupranay@users.noreply.github.com> Co-authored-by: Jeet Jain <jeet.jain@seagate.com> Co-authored-by: Saurabh Jain <91066893+sjain09@users.noreply.github.com> Co-authored-by: Parayya Vastrad <56255712+vastradparayya@users.noreply.github.com>
andriytk
pushed a commit
to andriytk/cortx-rgw
that referenced
this pull request
Mar 17, 2022
…eys (ceph#93) * rgw_sal_motr: [CORTX-28055] Support custom & multiple access/secret keys Added support for multple key creation for a user which can be either custom or auto generated. Signed-off-by: Jeet Jain <jeet.jain@seagate.com>
andriytk
pushed a commit
to andriytk/cortx-rgw
that referenced
this pull request
Mar 17, 2022
* Fix for CORTX-28869:Unable to create IAM user with email * Enable create user for same UID under different Tenant with motr as backend. (ceph#90) Signed-off-by: Diwakar92 <diwakar.kumar@seagate.com> Co-authored-by: kupranay <66459168+kupranay@users.noreply.github.com> * rgw_sal_motr: [CORTX-28055] Support custom & multiple access/secret keys (ceph#93) * rgw_sal_motr: [CORTX-28055] Support custom & multiple access/secret keys Added support for multple key creation for a user which can be either custom or auto generated. Signed-off-by: Jeet Jain <jeet.jain@seagate.com> * rgw_sal_motr: [EOS-27516] Handling object overwrite during put-object (ceph#89) * rgw_sal_motr: [EOS-27516] handling object overwrite Deleting existing object data if same object is uploaded again to avoid object leak. Signed-off-by: saurabh jain <saurabh.jain2@seagate.com> * rgw_sal_motr: [EOS-27516] Handle parallel upload During parallel object upload, there are chances of object leak, which can be handled by making use of GC. Since GC is not being use for motr as of now, adding a TODO for the same. Signed-off-by: saurabh jain <saurabh.jain@seagate.com> Co-authored-by: kupranay <66459168+kupranay@users.noreply.github.com> * Rebase (ceph#88) Signed-off-by: Parayya Vastrad <parayya.vastrad@seagate.com> * merge conflicts * merge conflicts * Review comments addressed * Review comments addressed Co-authored-by: root <root@ssc-vm-g4-rhev4-0716.colo.seagate.com> Co-authored-by: Diwakar92 <96409310+Diwakar92@users.noreply.github.com> Co-authored-by: kupranay <66459168+kupranay@users.noreply.github.com> Co-authored-by: Jeet Jain <jeet.jain@seagate.com> Co-authored-by: Saurabh Jain <91066893+sjain09@users.noreply.github.com> Co-authored-by: Parayya Vastrad <56255712+vastradparayya@users.noreply.github.com>
andriytk
pushed a commit
to andriytk/cortx-rgw
that referenced
this pull request
Apr 1, 2022
…eys creation (ceph#93) Add support for multiple key creation for a RGW Motr user which can be either custom (using --access-key=<key> or --secret-key=<key>) or auto generated (using --gen-access-key or --gen-secret) with radosgw-admin key create command or RGW rest api. Signed-off-by: Jeet Jain <jeet.jain@seagate.com>
galsalomon66
referenced
this pull request
in galsalomon66/ceph
Sep 17, 2022
* fix missing initialization for parquet_value. it cause failures for some tests in the case of /O3/ optimization * fix non-initialize variable. better failure report of gtest app * fix for file-pointer leak(test application). improve failure report. * boost installation had failed * incase of failure --> produce output * remove the shell-test. it is redundant, s3select_test contains all necessary tests Signed-off-by: gal salomon <gal.salomon@gmail.com>
Moisi
pushed a commit
to Moisi/ceph
that referenced
this pull request
Jun 30, 2025
Merge in STORAGEENG/ceph from bugfix/CEPH-207-backport-fix-in-ceph-upstream-with-pr-54999-to-our-v18-branches to aka_version_18.2.1 * commit '5a849834cafc1893b58a4f739038629f270ddc14': Remove an extra line added by accident. CEPH-207 Backport PR 54999 to Akamai v18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functions called from RGWGetObj_ObjStore_S3::send_response_data may
change the value of the non-local variable 'ret'. But the response
relies on a local 'req_state' which copies ret at the start of the
function.
Right now none of the called functions actually changes ret so the
problem doesn't trigger, but to avoid future breakage it is safer
to not rely on the (early) copy of the ret variable.
Signed-off-by: Jan Harkes jaharkes@cs.cmu.edu