Skip to content

Fixes for more cppcheck issues (v2 of #101)#102

Merged
liewegas merged 25 commits intoceph:masterfrom
dalgaaf:wip-da-sca-style-4-v2
Mar 12, 2013
Merged

Fixes for more cppcheck issues (v2 of #101)#102
liewegas merged 25 commits intoceph:masterfrom
dalgaaf:wip-da-sca-style-4-v2

Conversation

@dalgaaf
Copy link
Contributor

@dalgaaf dalgaaf commented Mar 12, 2013

These commits address issues like:

  • use static_cast instead of C-Style cast
  • remove unused variables
  • perform initialization of variables in initialization list of constructor
  • use %u to format unsigned in snprintf()
  • remove never executed statements after return
  • reduce scope of some variables
  • catch exception by reference
  • prefer prefix ++/--operator for non-primitive types

v2 of pull request #101

dalgaaf added 25 commits March 12, 2013 16:59
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
…list

Perform initialization of IntentLogNameFilter:prefix in initialization list
instead of constructor body.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Prefer prefix ++operator for non-primitive types like iterators for
performance reasons. Prefix ++/-- operators avoid creating a temporary
copy.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
liewegas added a commit that referenced this pull request Mar 12, 2013
Fixes for more cppcheck issues (v2 of #101)

Reviewed-by: Sage Weil <sage@inktank.com>
@liewegas liewegas merged commit 34f1984 into ceph:master Mar 12, 2013
@dalgaaf dalgaaf deleted the wip-da-sca-style-4-v2 branch March 12, 2013 17:10
liewegas pushed a commit that referenced this pull request Dec 14, 2016
ignore errors on informational service status
ricardoasmarques pushed a commit to ricardoasmarques/ceph that referenced this pull request Feb 19, 2018
mgr/dashboard_v2: Create links to perf counters
galsalomon66 referenced this pull request in galsalomon66/ceph Sep 17, 2022
* add rapidjson header files (https://github.com/Tencent/rapidjson master);  add test application
* add google-test, comparing sax parser against dom parser; editorial changes
* add rapidjson [https://github.com/Tencent/rapidjson.git] as submodule. the package has been used in CEPH is too old, not contain the iterative parsing that enables the chunk-by-chunk parsing
* filter key-path
* from-clause accepts JSON structure
* adding JSON SQL statements to be accepted by the s3select-parser. (*) new variable definition for JSON, enable access for a specific key path by the projection statements and where-clause predicates (*) editorial changes.
(*) add execution flow for JSON query processing. it is not cover all planned use-cases
(*) the JSON parser pushes JSON-values to scratch-area upon identifying matching key-path
(*) upon JSON parser is identifying a complete row it initiates s3select execution flow
(*) fix for the aggregation flow
(*) fix for execution flow upon end-of-input
(*) bug fix for column values
(*) the aggregation is not accurate, it misses the last part of the last chunk
* add case insensitive to assert
* fix for aggregation flow(end-of-stream).  fix case insensitive
* fix for language definition to accept when/case statement as an expression.
* fix for error handling in the test.
* fix for exception handling.
* add error handling.
* a fix(temporary) for the use-case where the value is very long and may cause parsing failure upon chunk "cut" that in the middle
* add an efficient flow for extracting JSON values, the flow minimizes the amount of data extraction by removing duplicate JSON-variables
* fix for language definition to accept when/case statement as an expression.
* rebase with row_definitions_rules
* fix the execution flow per JSON, "break" the loop per each row
* a fix for the use-case where the from-clause is empty.
* JSON-parser: adding member-data for better describing the state of each key-value
* adding JSON test queries to the main g-test
* fix for exact-match filter (json variables)
* fix for result handling
* add star operation per JSON queries.
upon star-operation(select *) the engine&JSON-parser extract *all* key-full-path and value according to from-clause and where-clause(if exists).
engine&parser should be aware to JSON statement syntax, and to star-operation reside in SQL statement.
the result per star-operation is displayed differently, with each column on a separate line, and each resulted row ends with row-number.
* error handling: upon runtime error, to handle the exception
* a fix for syntax-parser (push_json_variable)
* fix for json-from-clause (remove strdup)

Signed-off-by: gal salomon <gal.salomon@gmail.com>
Signed-off-by: Albin Antony <aantony@redhat.com>
Co-authored-by: Albin Antony <aantony@redhat.com>
Moisi pushed a commit to Moisi/ceph that referenced this pull request Jun 30, 2025
…ctly

Merge in STORAGEENG/ceph from bugfix/CEPH-214-missing-element-from-listmultipartuploads-ceph-response-qa to aka_version_18.2.1

* commit 'c6f6a3979fc36eabf6ccc260182be80bc303ca40':
  Handle multiple common prefixes correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants