Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1505 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 189 193 +4
Lines 24670 24965 +295
Branches 4010 4042 +32
==========================================
+ Hits 24670 24965 +295
🚀 New features to boost your workflow:
|
|
I have asked the Slixmpp developers to have a look. Here's the reply I received yesterday:
|
|
@mbeko , thank you. I'm actually quite happy with the latest version. I've gotten everything to work in my own test environment as well. I fixed the Thank you for reaching out for help; to your comments:
This is now handled in this build so we're good.
The
While i have a Documentation preview is here: https://dev.appriseit.com/services/xmpp/. 100% test coverage, so that part is good to go as well. I think this is ready to go, but would definitely appreciation anyone's further feedback. |
|
Wow, great work! 👏 I'll see if I can get some final feedback from the devs. Tomorrow, I should be able to review the documentation, and test with various parameter combinations. Nice documentation page, by the way! I somehow missed that the information isn't maintained in the GitHub wiki anymore |
|
Here are some final comments from the Slixmpp devs:
seems ok to me, two remarks:
- slixmpp.JID could be used for JID parsing instead of the regex
- I don’t think get_roster() is strictly necessary (but doesn’t hurt much)
The JID class will likely be faster than a regex indeed.
|
|
I didn't touch the JID update... but something for a later release perhaps. I did fix the roster point and it's now optional (defaults to off unless |
Description
Related issue (if applicable): #497
This PR restores XMPP notification support to Apprise using slixmpp with a modernized implementation.
XMPP Notifications
Send notifications to XMPP users (JIDs). Each notification establishes a temporary connection, sends the message, and cleanly disconnects.
Account Setup
Syntax
Valid syntax is as follows:
xmpp://{user}:{password}@{host}/xmpps://{user}:{password}@{host}:{port}/xmpp://{user}:{password}@{host}/{target}xmpps://{user}:{password}@{host}:{port}/{target}Targets may also be supplied via the
to=query argument.Parameter Breakdown
none,starttls, ortlsto enforce the secure mode usedget_roster()under the hood after the XMPP connection is established (default: no)New Service Completion Status
%global common_descriptionChecklist
tox -e lintand optionallytox -e format).tox -e minimal).Testing
Anyone can help test as follows: