Skip to content

Refactored XMPP notification service#220

Merged
caronc merged 2 commits intomasterfrom
refactor-xmpp-plugin-update
Mar 29, 2020
Merged

Refactored XMPP notification service#220
caronc merged 2 commits intomasterfrom
refactor-xmpp-plugin-update

Conversation

@caronc
Copy link
Owner

@caronc caronc commented Mar 27, 2020

Description:

Related issue (if applicable): #213
A slight re-factor of #217 with the addition of more unit testing

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

@caronc caronc changed the title refactored xmpp notification service; refs #217 Refactored XMPP notification service Mar 27, 2020
@caronc caronc force-pushed the refactor-xmpp-plugin-update branch from 55b1408 to 239c5c8 Compare March 27, 2020 17:37
@caronc caronc force-pushed the refactor-xmpp-plugin-update branch from 239c5c8 to c9a0678 Compare March 27, 2020 17:51
@caronc caronc mentioned this pull request Mar 27, 2020
@caronc caronc force-pushed the refactor-xmpp-plugin-update branch from 3a18cd7 to 69189b6 Compare March 29, 2020 01:06
@codecov-io
Copy link

codecov-io commented Mar 29, 2020

Codecov Report

Merging #220 into master will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #220      +/-   ##
===========================================
+ Coverage   99.78%   100.00%   +0.21%     
===========================================
  Files          74        75       +1     
  Lines        8815      8827      +12     
  Branches     1422      1422              
===========================================
+ Hits         8796      8827      +31     
+ Misses         16         0      -16     
+ Partials        3         0       -3     
Impacted Files Coverage Δ
apprise/plugins/NotifyXMPP/SleekXmppAdapter.py 100.00% <100.00%> (ø)
apprise/plugins/NotifyXMPP/__init__.py 100.00% <100.00%> (ø)
apprise/plugins/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c251bf...69189b6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants