Codecov Report

Merging #447 (7b320ed) into master (1666f39) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #447   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           97        97           
  Lines        12509     12509           
  Branches      2116      2116           
=========================================
  Hits         12509     12509           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1666f39...7b320ed. Read the comment docs.

@gaby, I appreciate your pull request, bu i left out the dependency intentionally actually. 🙂

The problem with making it a dependency is that it's a bigger library you need to pull in for only those using MQTT.
It works the same as how XMPP works (see here). Basically not everyone will want to use it, so it's a lot to pull in for nothing. The warning on MQTT should be enough to get people to install the paho-mqtt library for those who want to use it for now.

There is a windows:// plugin too that requires an extra package; similarly, I don't force everyone to install it because not everyone wants to use it.

The good news is that of my unit tests pull in paho-mqtt so i do a proper testing on the (MQTT) module from a dev side of things. 👍 (dev dependencies for some custom plugins)

Down the road, i think the proper solution might be to setup Sub Packages. That way the XMPP sub-package would include it's dependencies just as the MQTT one would. That way you would only have to install what you want.

@caronc Makes total sense, thanks for the great explanation. I'm going to close this one then!