Skip to content

slixmpp library support added to XMPP plugin#240

Merged
caronc merged 3 commits intomasterfrom
227-xmpp-slixmpp-support
Feb 22, 2021
Merged

slixmpp library support added to XMPP plugin#240
caronc merged 3 commits intomasterfrom
227-xmpp-slixmpp-support

Conversation

@caronc
Copy link
Owner

@caronc caronc commented Jun 9, 2020

Description:

Related issue (if applicable): #227

XMPP support already uses the sleekxmpp library which is no longer maintained. This merge request introduces support for slixmpp which is it's successor.

Sources

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2020

Codecov Report

Merging #240 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #240    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           83        78     -5     
  Lines         9846      9133   -713     
  Branches      1603      1471   -132     
==========================================
- Hits          9846      9133   -713     
Impacted Files Coverage Δ
apprise/plugins/NotifyXMPP/SliXmppAdapter.py 100.00% <100.00%> (ø)
apprise/plugins/NotifyXMPP/__init__.py 100.00% <100.00%> (ø)
apprise/plugins/__init__.py 100.00% <100.00%> (ø)
apprise/utils.py 100.00% <0.00%> (ø)
apprise/Apprise.py 100.00% <0.00%> (ø)
apprise/URLBase.py 100.00% <0.00%> (ø)
apprise/AppriseAsset.py 100.00% <0.00%> (ø)
apprise/config/ConfigBase.py 100.00% <0.00%> (ø)
apprise/config/ConfigHTTP.py 100.00% <0.00%> (ø)
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e1b8a0...d0709c4. Read the comment docs.

@caronc caronc added the blocked Blocked due to missing information and/or an issue outside of this project. label Jun 13, 2020
@caronc caronc force-pushed the 227-xmpp-slixmpp-support branch from e03a069 to d0709c4 Compare August 18, 2020 19:10
@caronc
Copy link
Owner Author

caronc commented Aug 18, 2020

Created this ticket to resolve slixmpp issues with this pull request.

@caronc caronc force-pushed the master branch 3 times, most recently from 4926a03 to 93efa2d Compare August 31, 2020 17:31
@caronc caronc force-pushed the 227-xmpp-slixmpp-support branch from d0709c4 to adf7e5f Compare February 22, 2021 20:21
@caronc caronc removed the blocked Blocked due to missing information and/or an issue outside of this project. label Feb 22, 2021
@caronc
Copy link
Owner Author

caronc commented Feb 22, 2021

Workaround in place allowing me to unblock this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants