0.16: Remaining backports for 0.16.2 #13644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought we had removed this a long time ago, TBH, its really confusing feedback to users that we display whether a tx was broadcast to immediate neighbor nodes, given that has little indication of whether the tx propagated very far. Github-Pull: bitcoin#13622 Rebased-From: beef7ec
Added handling for the case where headers are announced over more than one message. refs bitcoin#12453 Github-Pull: bitcoin#13192 Rebased-From: 12d1b77
Github-Pull: bitcoin#13304 Rebased-From: fa865ef
Github-Pull: bitcoin#12793 Rebased-From: 342fb80
Log messages should terminate with a '\n', or the following log will be written to the same line without a timestamp. Fix a couple of cases where the message is not terminated with a \n. Github-Pull: bitcoin#12887 Rebased-From: 5b10ab0
Github-Pull: bitcoin#12837 Rebased-From: 05c03d1
Larger values seem to trigger a bug on macos+libevent (resulting in the rpc server stopping). Github-Pull: bitcoin#12905 Rebased-From: 662d19f
Member
Member
Author
|
@fanquake thanks. I will go through all master changes again and then include those two as well (and any other I find on the way) |
also test that 64 bit integers are properly handled Github-Pull: bitcoin#13061 Rebased-From: 3ee4be1
Github-Pull: bitcoin#13545 Rebased-From: c6fd0df
Github-Pull: bitcoin#13545 Rebased-From: 962d8ee
Github-Pull: bitcoin#13437 Rebased-From: faa18ca
32fce4e to
ed82e71
Compare
Github-Pull: bitcoin#13452 Rebased-From: ed82f17
Github-Pull: bitcoin#13452 Rebased-From: d280617
#ifdef is not correct since defination is defined to 0 or 1. Should change to #if Github-Pull: bitcoin#12573 Rebased-From: 1830784
Github-Pull: bitcoin#12743 Rebased-From: 45dd135
21966b4 to
b72c0bd
Compare
Member
|
Missing:
|
Member
Author
Github-Pull: bitcoin#12432 Rebased-From: f506c0a
Currently, error messages (such as InitError) are displayed as-is, which means Qt does auto detection on the format. This means that it's possible to inject HTML from the command line though e.g. specifying a wallet name with HTML in it. This isn't a direct security risk because fetching content from internet is disabled (and as far as I know we never report strings received from the network this way). However, it can be confusing. So explicitly force the format as text. Github-Pull: bitcoin#12617 Rebased-From: 6fbc098
Member
Author
|
Done |
Contributor
|
ACK |
1 similar comment
Member
|
ACK |
This was referenced Jul 13, 2018
Member
|
utACK 21dd512 |
Github-Pull: bitcoin#13300 Rebased-From: fa9da85
668ece0 to
d9c5630
Compare
Member
Author
|
Pushed a commit to fix a test debugging issue reported by a user on the bitcoin-dev mailing list. https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2018-July/016255.html |
Member
|
utACK d9c5630 |
Contributor
|
re-ACK |
Member
|
re-utACK d9c5630 |
Member
|
utACK d9c5630 |
laanwj
added a commit
that referenced
this pull request
Jul 16, 2018
d9c5630 qa: Initialize lockstack to prevent null pointer deref (MarcoFalke) 21dd512 gui: Show messages as text not html (Wladimir J. van der Laan) f78e7f6 [qt] send: Clear All also resets coin control options (Sjors Provoost) 657dfc5 Fix csBestBlock/cvBlockChange waiting in rpc/mining (Pieter Wuille) 88d1a64 Consensus: Fix bug when compiler do not support __builtin_clz* (532479301) b72c0bd [qa] Add a test for merkle proof malleation (Suhas Daftuar) 6b9dc8c have verifytxoutproof check the number of txns in proof structure (Gregory Sanders) ed82e71 wallet: Erase wtxOrderd wtx pointer on removeprunedfunds (MarcoFalke) e15e3a9 Remove boost dependency (boost/assign/std/vector.hpp) (practicalswift) 1062199 Fix incorrect tests (practicalswift) 170b309 Make tests pass after 2020 (Bernhard M. Wiedemann) cfc6f74 [rpcwallet] Clamp walletpassphrase value at 100M seconds (Suhas Daftuar) bf1f150 rpc: fix type mistmatch in listreceivedbyaddress (joemphilips) 2291774 [trivial] Add newlines to end of log messages. (John Newbery) cf6feb7 qt: Avoid resetting on resetguisettigs=0 (MarcoFalke) cbdabef qa: Fix wallet_listreceivedby race (MarcoFalke) 79c4fff [tests] Fixed intermittent failure in p2p_sendheaders.py. (lmanners) c04a4a5 Remove useless mapRequest tracking that just effects Qt display. (Matt Corallo) Pull request description: Some gui/doc/rpc/qa backports Tree-SHA512: f1e918d2ca6016fc7c5d5adf5d537553a1769731e2dcac788edf02c7354387861ec5bcd0cbf3c833c1485d500c55a73a2799a8b39ed14477524ac46b4ff2332d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
17 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some gui/doc/rpc/qa backports