qa: Fix wallet_listreceivedby race #13304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
One of the travis failures for reference: https://travis-ci.org/bitcoin/bitcoin/jobs/377321319 |
fa19528 to
faf20a7
Compare
Contributor
|
utACK faf20a7 |
jnewbery
reviewed
May 23, 2018
Contributor
There was a problem hiding this comment.
You can use self.sync_all() here to avoid the additional import.
Contributor
There was a problem hiding this comment.
No need to remove this. It looks like this log indicates that this part of the test is for listreceivedbyaddress compared with the next parts of the test for getreceivedbyaddress and listreceivedbylabel/getreceivedbylabel.
Member
Author
There was a problem hiding this comment.
Thanks. Removing the log statement was incorrect. Fixed up...
faf20a7 to
fa865ef
Compare
Contributor
|
Tested ACK fa865ef |
maflcko
pushed a commit
that referenced
this pull request
May 24, 2018
fa865ef qa: Fix wallet_listreceivedby race (MarcoFalke) Pull request description: Generating a block on node 0 will only get node 0 out of IBD and not node 1. So the inv for the `txid` is dropped by node 1 and the call to `sync_all` fails. Solve it by a call to `sync_blocks` after `generate`. Tree-SHA512: e21b01a9e8c90bd6a3aad290c97cc4866ab384e22797b318eed55ae2767512203597d3a184b23ad5a3fe76bdbb8a3d5c51e097d56b160232851164434059ff23
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
May 29, 2018
Github-Pull: bitcoin#13304 Rebased-From: fa865ef
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Jul 12, 2018
Github-Pull: bitcoin#13304 Rebased-From: fa865ef
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 11, 2019
Summary: fa865ef qa: Fix wallet_listreceivedby race (MarcoFalke) Pull request description: Generating a block on node 0 will only get node 0 out of IBD and not node 1. So the inv for the `txid` is dropped by node 1 and the call to `sync_all` fails. Solve it by a call to `sync_blocks` after `generate`. Tree-SHA512: e21b01a9e8c90bd6a3aad290c97cc4866ab384e22797b318eed55ae2767512203597d3a184b23ad5a3fe76bdbb8a3d5c51e097d56b160232851164434059ff23 Backport of Core PR13304 bitcoin/bitcoin#13304 Test Plan: test_runner.py wallet_listreceivedby Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc Reviewed By: deadalnix, O1 Bitcoin ABC, #bitcoin_abc Differential Revision: https://reviews.bitcoinabc.org/D4164
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Apr 16, 2020
fa865ef qa: Fix wallet_listreceivedby race (MarcoFalke) Pull request description: Generating a block on node 0 will only get node 0 out of IBD and not node 1. So the inv for the `txid` is dropped by node 1 and the call to `sync_all` fails. Solve it by a call to `sync_blocks` after `generate`. Tree-SHA512: e21b01a9e8c90bd6a3aad290c97cc4866ab384e22797b318eed55ae2767512203597d3a184b23ad5a3fe76bdbb8a3d5c51e097d56b160232851164434059ff23
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating a block on node 0 will only get node 0 out of IBD and not node 1. So the inv for the
txidis dropped by node 1 and the call tosync_allfails.Solve it by a call to
sync_blocksaftergenerate.