Skip to content

Conversation

@practicalswift
Copy link
Contributor

  • Fix test case streams_serializedata_xor.
  • Remove Boost dependency.

@fanquake fanquake added the Tests label Jun 27, 2018
@laanwj
Copy link
Member

laanwj commented Jun 29, 2018

utACK 962d8ee

1 similar comment
@maflcko
Copy link
Member

maflcko commented Jun 29, 2018

utACK 962d8ee

@maflcko maflcko merged commit 962d8ee into bitcoin:master Jun 29, 2018
maflcko pushed a commit that referenced this pull request Jun 29, 2018
…Boost dependency.

962d8ee Remove boost dependency (boost/assign/std/vector.hpp) (practicalswift)
c6fd0df Fix incorrect tests (practicalswift)

Pull request description:

  * Fix test case `streams_serializedata_xor`.
  * Remove Boost dependency.

Tree-SHA512: 609c4ced1b6a8b86f6a37e4220535f1b3c9f2e80949cd034ecc069a94c55c05cd514f2e132fe7f715161ee29811a0fadb6903635c507411d8dc3e7efe864edeb
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Jul 13, 2018
Github-Pull: bitcoin#13545
Rebased-From: c6fd0df
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Jul 13, 2018
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Apr 16, 2020
…ta_xor. Remove Boost dependency.

962d8ee Remove boost dependency (boost/assign/std/vector.hpp) (practicalswift)
c6fd0df Fix incorrect tests (practicalswift)

Pull request description:

  * Fix test case `streams_serializedata_xor`.
  * Remove Boost dependency.

Tree-SHA512: 609c4ced1b6a8b86f6a37e4220535f1b3c9f2e80949cd034ecc069a94c55c05cd514f2e132fe7f715161ee29811a0fadb6903635c507411d8dc3e7efe864edeb
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Jun 1, 2020
…Boost dependency.

Summary:
962d8ee Remove boost dependency (boost/assign/std/vector.hpp) (practicalswift)
c6fd0df Fix incorrect tests (practicalswift)

Pull request description:

  * Fix test case `streams_serializedata_xor`.
  * Remove Boost dependency.

Tree-SHA512: 609c4ced1b6a8b86f6a37e4220535f1b3c9f2e80949cd034ecc069a94c55c05cd514f2e132fe7f715161ee29811a0fadb6903635c507411d8dc3e7efe864edeb

Backport of Core [[bitcoin/bitcoin#13545 | PR13545]]

Test Plan:
  ninja check
  arc lint

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6320
ftrader pushed a commit to bitcoin-cash-node/bitcoin-cash-node that referenced this pull request Aug 17, 2020
…Boost dependency.

Summary:
962d8ee Remove boost dependency (boost/assign/std/vector.hpp) (practicalswift)
c6fd0df Fix incorrect tests (practicalswift)

Pull request description:

  * Fix test case `streams_serializedata_xor`.
  * Remove Boost dependency.

Tree-SHA512: 609c4ced1b6a8b86f6a37e4220535f1b3c9f2e80949cd034ecc069a94c55c05cd514f2e132fe7f715161ee29811a0fadb6903635c507411d8dc3e7efe864edeb

Backport of Core [[bitcoin/bitcoin#13545 | PR13545]]

Test Plan:
  ninja check
  arc lint

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6320
@practicalswift practicalswift deleted the fix-test-and-de-boost branch April 10, 2021 19:35
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Feb 8, 2022
…ta_xor. Remove Boost dependency.

962d8ee Remove boost dependency (boost/assign/std/vector.hpp) (practicalswift)
c6fd0df Fix incorrect tests (practicalswift)

Pull request description:

  * Fix test case `streams_serializedata_xor`.
  * Remove Boost dependency.

Tree-SHA512: 609c4ced1b6a8b86f6a37e4220535f1b3c9f2e80949cd034ecc069a94c55c05cd514f2e132fe7f715161ee29811a0fadb6903635c507411d8dc3e7efe864edeb
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants