[tests] Fixed intermittent failure in p2p_sendheaders.py. #13192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added handling for the case where headers are announced over more than one message. refs bitcoin#12453
Member
|
Concept ACK |
jnewbery
reviewed
May 9, 2018
Contributor
jnewbery
left a comment
There was a problem hiding this comment.
Thanks for this contribution @lmanners. Looks great!
Tested ACK 12d1b77. I've run this 100 times locally and not been able to reproduce the error (although note that this was a timing error that was previously only seen on Travis).
A nit and a comment inline, but no need to update the branch for either of those. I think this can be merged as is.
| if len(message.headers): | ||
| self.block_announced = True | ||
| message.headers[-1].calc_sha256() | ||
| for x in message.headers: |
Contributor
There was a problem hiding this comment.
nit: prefer header as variable name over x
|
|
||
| inv_node.check_last_announcement(inv=[tip_hash], headers=[]) | ||
| test_node.check_last_announcement(inv=[tip_hash], headers=[]) | ||
| inv_node.check_last_inv_announcement(inv=[tip_hash]) |
Contributor
There was a problem hiding this comment.
Calling the method with a named argument isn't strictly necessary, since the method only takes a single argument now, but it does no harm.
Member
|
utACK 12d1b77 |
maflcko
pushed a commit
that referenced
this pull request
May 10, 2018
12d1b77 [tests] Fixed intermittent failure in p2p_sendheaders.py. (lmanners) Pull request description: Added handling for the case where headers are announced over more than one message. refs #12453 Tree-SHA512: 2c5b48ff019089b86e358181ba170d3aac09d4ae41ec79c2718e0ee83705860501bbcb8fd94d0f5c4f86c0d54a96781a967716621bb8c5ecc991b39af3cec506
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
May 29, 2018
Added handling for the case where headers are announced over more than one message. refs bitcoin#12453 Github-Pull: bitcoin#13192 Rebased-From: 12d1b77
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Jul 12, 2018
Added handling for the case where headers are announced over more than one message. refs bitcoin#12453 Github-Pull: bitcoin#13192 Rebased-From: 12d1b77
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Apr 16, 2020
…aders.py. 12d1b77 [tests] Fixed intermittent failure in p2p_sendheaders.py. (lmanners) Pull request description: Added handling for the case where headers are announced over more than one message. refs bitcoin#12453 Tree-SHA512: 2c5b48ff019089b86e358181ba170d3aac09d4ae41ec79c2718e0ee83705860501bbcb8fd94d0f5c4f86c0d54a96781a967716621bb8c5ecc991b39af3cec506
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added handling for the case where headers are announced over more than one message.
refs #12453