Revert "Yank obsolete rules_go and gazelle versions"#733
Closed
werkt wants to merge 1 commit intobazelbuild:mainfrom
Closed
Revert "Yank obsolete rules_go and gazelle versions"#733werkt wants to merge 1 commit intobazelbuild:mainfrom
werkt wants to merge 1 commit intobazelbuild:mainfrom
Conversation
This reverts commit e91124a.
Contributor
|
Since Bzlmod uses Minimum Version Selection, it should suffice to temporarily add a After CI is green again, we can add a new, BCR-only version of |
Contributor
|
Cc @Wyverald |
werkt
added a commit
to werkt/bazel
that referenced
this pull request
Jul 2, 2023
bazelbuild/bazel-central-registry#725 broke bazel CI asynchronously by yanking rules_go@0.34.0, listed as a dependency on BCR of grpc@1.48.1. From BCR recommendation on bazelbuild/bazel-central-registry#733, specifying a rules_go@0.38.1 should coerce transitive selection through Minimum Version Selection.
werkt
added a commit
to werkt/bazel
that referenced
this pull request
Jul 2, 2023
bazelbuild/bazel-central-registry#725 broke bazel CI asynchronously by yanking rules_go@0.34.0, listed as a dependency on BCR of grpc@1.48.1. From BCR recommendation on bazelbuild/bazel-central-registry#733, specifying a rules_go@0.39.1 should coerce transitive selection through Minimum Version Selection.
Author
|
rules_go is similarly afflicted with gazelle at the recommended 0.38.1. Trying for 0.39.1 which moves the bar on gazelle to 0.30.0 |
Author
|
bazel CI green for bzlmod builds with bazelbuild/bazel#18828: rules_go@0.39.1 |
Contributor
|
Thanks for the report and PR! As discussed above, let's fix this forward with #734 and your Bazel PR. |
copybara-service bot
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Jul 3, 2023
bazelbuild/bazel-central-registry#725 broke bazel CI asynchronously by yanking rules_go@0.34.0, listed as a dependency on BCR of grpc@1.48.1. From BCR recommendation on bazelbuild/bazel-central-registry#733, specifying a rules_go@0.39.1 should coerce transitive selection through Minimum Version Selection (and bypass gazelle@0.27.0, also yanked). Closes #18828. PiperOrigin-RevId: 545205842 Change-Id: I574fc46b7c09e72e6d70ef77be726897aacc4358
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
Jul 12, 2023
bazelbuild/bazel-central-registry#725 broke bazel CI asynchronously by yanking rules_go@0.34.0, listed as a dependency on BCR of grpc@1.48.1. From BCR recommendation on bazelbuild/bazel-central-registry#733, specifying a rules_go@0.39.1 should coerce transitive selection through Minimum Version Selection (and bypass gazelle@0.27.0, also yanked). Closes bazelbuild#18828. PiperOrigin-RevId: 545205842 Change-Id: I574fc46b7c09e72e6d70ef77be726897aacc4358
fweikert
added a commit
to bazelbuild/bazel
that referenced
this pull request
Jul 12, 2023
bazelbuild/bazel-central-registry#725 broke bazel CI asynchronously by yanking rules_go@0.34.0, listed as a dependency on BCR of grpc@1.48.1. From BCR recommendation on bazelbuild/bazel-central-registry#733, specifying a rules_go@0.39.1 should coerce transitive selection through Minimum Version Selection (and bypass gazelle@0.27.0, also yanked). Closes #18828. PiperOrigin-RevId: 545205842 Change-Id: I574fc46b7c09e72e6d70ef77be726897aacc4358 Co-authored-by: George Gensure <werkt0@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #725
This is breaking bazel's CI: https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/16408 and all other builds on master since this landed have failed due to a grpc@1.48.1 -> rules_go@0.34.0 chain. The rules_go version may be fluid enough to change for grpc, but since CI guards against this with "Existing modules should not be changed" checks, bazel CI will be broken until a new version of grpc is released to BCR and bazel is made to depend upon it, for which there may not be an upstream version that is compatible without further changes to bazel core.