Merged
Conversation
This was referenced Jul 2, 2023
Member
|
After this has been merged (likely after the US holidays) and Bazel has been updated we need to revert bazelbuild/bazel#18828 |
alexeagle
approved these changes
Jul 6, 2023
Contributor
|
Drive-by comment - does the grpc repo actually contain Go code? It seems like we've done something wrong with grpc needs to depend on ~all languages that end-users might want a grpc runtime for... |
Contributor
Author
|
CI proves that rules_go is a required dep. I fully agree that this shouldn't be the case and |
Bumps the versions of `zlib` and `rules_go` passed all yanked versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the versions of
zlibandrules_gopast all yanked versions.