Skip to content

Add temporary rules_go bazel_dep to restore CI#18828

Closed
werkt wants to merge 1 commit intobazelbuild:masterfrom
werkt:rules_go-grpc-ci
Closed

Add temporary rules_go bazel_dep to restore CI#18828
werkt wants to merge 1 commit intobazelbuild:masterfrom
werkt:rules_go-grpc-ci

Conversation

@werkt
Copy link
Copy Markdown
Contributor

@werkt werkt commented Jul 2, 2023

bazelbuild/bazel-central-registry#725 broke bazel CI asynchronously by yanking rules_go@0.34.0, listed as a dependency on BCR of grpc@1.48.1. From BCR recommendation on bazelbuild/bazel-central-registry#733, specifying a rules_go@0.39.1 should coerce transitive selection through Minimum Version Selection (and bypass gazelle@0.27.0, also yanked).

@werkt werkt requested a review from Wyverald July 2, 2023 06:16
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jul 2, 2023
@werkt werkt requested a review from fmeum July 2, 2023 06:16
bazelbuild/bazel-central-registry#725 broke
bazel CI asynchronously by yanking rules_go@0.34.0, listed as a
dependency on BCR of grpc@1.48.1. From BCR recommendation on
bazelbuild/bazel-central-registry#733,
specifying a rules_go@0.39.1 should coerce transitive selection through
Minimum Version Selection.
@fmeum
Copy link
Copy Markdown
Collaborator

fmeum commented Jul 2, 2023

@werkt I submitted bazelbuild/bazel-central-registry#734. After it has been merged we can go straight for the grpc update.

@sgowroji sgowroji added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jul 3, 2023
@copybara-service copybara-service bot closed this in 6c393ec Jul 3, 2023
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Jul 3, 2023
@werkt werkt deleted the rules_go-grpc-ci branch July 3, 2023 20:50
fweikert pushed a commit to fweikert/bazel that referenced this pull request Jul 12, 2023
bazelbuild/bazel-central-registry#725 broke bazel CI asynchronously by yanking rules_go@0.34.0, listed as a dependency on BCR of grpc@1.48.1. From BCR recommendation on bazelbuild/bazel-central-registry#733, specifying a rules_go@0.39.1 should coerce transitive selection through Minimum Version Selection (and bypass gazelle@0.27.0, also yanked).

Closes bazelbuild#18828.

PiperOrigin-RevId: 545205842
Change-Id: I574fc46b7c09e72e6d70ef77be726897aacc4358
fweikert added a commit that referenced this pull request Jul 12, 2023
bazelbuild/bazel-central-registry#725 broke bazel CI asynchronously by yanking rules_go@0.34.0, listed as a dependency on BCR of grpc@1.48.1. From BCR recommendation on bazelbuild/bazel-central-registry#733, specifying a rules_go@0.39.1 should coerce transitive selection through Minimum Version Selection (and bypass gazelle@0.27.0, also yanked).

Closes #18828.

PiperOrigin-RevId: 545205842
Change-Id: I574fc46b7c09e72e6d70ef77be726897aacc4358

Co-authored-by: George Gensure <werkt0@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants