Skip to content

Yank obsolete rules_go and gazelle versions#725

Merged
Wyverald merged 4 commits intomainfrom
fmeum-patch-1
Jun 30, 2023
Merged

Yank obsolete rules_go and gazelle versions#725
Wyverald merged 4 commits intomainfrom
fmeum-patch-1

Conversation

@fmeum
Copy link
Copy Markdown
Contributor

@fmeum fmeum commented Jun 30, 2023

These version were marked as experimental, which resulted in print warnings whenever their module files are evaluated. As they are still discovered starting from modern versions of these rulesets, the warnings ended up affecting all users.

By yanking these versions, Bazel 6.3.0 and later will no longer emit the warnings.

@fmeum fmeum marked this pull request as ready for review June 30, 2023 11:49
@fmeum fmeum requested review from Wyverald and meteorcloudy June 30, 2023 11:50
@meteorcloudy
Copy link
Copy Markdown
Member

Can you include also which version should users upgrade to?

@fmeum
Copy link
Copy Markdown
Contributor Author

fmeum commented Jun 30, 2023

Can you include also which version should users upgrade to?

Good idea, done!

@Wyverald Wyverald merged commit e91124a into main Jun 30, 2023
@werkt
Copy link
Copy Markdown

werkt commented Jul 2, 2023

This is breaking bazel's CI: https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/16408 and all other builds on master since this landed. The problem seems to be introduced with bazel's bazel_dep(name = "grpc", version = "1.48.1", repo_name = "com_github_grpc_grpc") dependency, but I don't see the line drawn from this to the rules_go - local queries at least don't error on the yanked version when I disable this line.

werkt added a commit to werkt/bazel-central-registry that referenced this pull request Jul 2, 2023
@werkt
Copy link
Copy Markdown

werkt commented Jul 2, 2023

With further guidance that Existing modules should not be changed provided by BCR CI in https://buildkite.com/bazel/bcr-presubmit/builds/1559#0189152c-34cb-415b-bc78-14f9f182f223, this has broken bazel until a new version of grpc can be depended upon. I'm going to put up a revert PR for this, and hope that will be considered.

werkt added a commit to werkt/bazel that referenced this pull request Jul 2, 2023
bazelbuild/bazel-central-registry#725 broke
bazel CI asynchronously by yanking rules_go@0.34.0, listed as a
dependency on BCR of grpc@1.48.1. From BCR recommendation on
bazelbuild/bazel-central-registry#733,
specifying a rules_go@0.38.1 should coerce transitive selection through
Minimum Version Selection.
werkt added a commit to werkt/bazel that referenced this pull request Jul 2, 2023
bazelbuild/bazel-central-registry#725 broke
bazel CI asynchronously by yanking rules_go@0.34.0, listed as a
dependency on BCR of grpc@1.48.1. From BCR recommendation on
bazelbuild/bazel-central-registry#733,
specifying a rules_go@0.39.1 should coerce transitive selection through
Minimum Version Selection.
copybara-service bot pushed a commit to bazelbuild/bazel that referenced this pull request Jul 3, 2023
bazelbuild/bazel-central-registry#725 broke bazel CI asynchronously by yanking rules_go@0.34.0, listed as a dependency on BCR of grpc@1.48.1. From BCR recommendation on bazelbuild/bazel-central-registry#733, specifying a rules_go@0.39.1 should coerce transitive selection through Minimum Version Selection (and bypass gazelle@0.27.0, also yanked).

Closes #18828.

PiperOrigin-RevId: 545205842
Change-Id: I574fc46b7c09e72e6d70ef77be726897aacc4358
@fmeum fmeum deleted the fmeum-patch-1 branch July 5, 2023 09:58
fweikert pushed a commit to fweikert/bazel that referenced this pull request Jul 12, 2023
bazelbuild/bazel-central-registry#725 broke bazel CI asynchronously by yanking rules_go@0.34.0, listed as a dependency on BCR of grpc@1.48.1. From BCR recommendation on bazelbuild/bazel-central-registry#733, specifying a rules_go@0.39.1 should coerce transitive selection through Minimum Version Selection (and bypass gazelle@0.27.0, also yanked).

Closes bazelbuild#18828.

PiperOrigin-RevId: 545205842
Change-Id: I574fc46b7c09e72e6d70ef77be726897aacc4358
fweikert added a commit to bazelbuild/bazel that referenced this pull request Jul 12, 2023
bazelbuild/bazel-central-registry#725 broke bazel CI asynchronously by yanking rules_go@0.34.0, listed as a dependency on BCR of grpc@1.48.1. From BCR recommendation on bazelbuild/bazel-central-registry#733, specifying a rules_go@0.39.1 should coerce transitive selection through Minimum Version Selection (and bypass gazelle@0.27.0, also yanked).

Closes #18828.

PiperOrigin-RevId: 545205842
Change-Id: I574fc46b7c09e72e6d70ef77be726897aacc4358

Co-authored-by: George Gensure <werkt0@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants