Private Static Class Methods (Stage 3)#9446
Merged
nicolo-ribaudo merged 9 commits intobabel:masterfrom Mar 12, 2019
Merged
Conversation
8893a12 to
f502e36
Compare
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10419/ |
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9967/ |
Contributor
Author
|
@nicolo-ribaudo should this be considered a part of the |
Member
|
I'd say yes, but let's also wait for @littledan 's opinion. |
|
Yes, I would include it in the private methods package. (If anyone has concerns, please let me know and I can provide more detailed rationale.) |
f502e36 to
c0cdb5d
Compare
c0cdb5d to
5b2b943
Compare
Contributor
Author
|
I've incorporated changes from #9508 into my PR since it solves a problem I ran into with handling |
060980b to
22784fe
Compare
Contributor
Author
|
Support for both spec and loose modes have now been added. I'll see if I can figure out any more necessary test cases, but I think the PR is ready to start reviewing at this point. cc: @nicolo-ribaudo Keep in mind that un-merged changes from #9508 are present in this PR as well. |
Member
|
I have merged #9508 |
...ges/babel-plugin-proposal-private-methods/test/fixtures/private-static-method/basic/input.js
Show resolved
Hide resolved
packages/babel-helper-create-class-features-plugin/src/fields.js
Outdated
Show resolved
Hide resolved
22784fe to
fcc885a
Compare
Contributor
Author
|
@nicolo-ribaudo thanks, updated. |
a2c7da1 to
eedf3b3
Compare
packages/babel-helper-create-class-features-plugin/src/fields.js
Outdated
Show resolved
Hide resolved
eedf3b3 to
6cf450f
Compare
nicolo-ribaudo
approved these changes
Feb 27, 2019
packages/babel-helper-create-class-features-plugin/src/fields.js
Outdated
Show resolved
Hide resolved
87781fd to
717c7f9
Compare
717c7f9 to
1ff5e2a
Compare
1ff5e2a to
c58bad1
Compare
Contributor
Author
|
Erm... not sure why this happened |
Member
|
We enabled it to avoid size regressions but it doesn't work well after rebases. |
Contributor
Author
|
I removed the "WIP" comment from the description. The PR is ready on my end. |
Member
|
Thank you! |
This was referenced Mar 13, 2019
mAAdhaTTah
added a commit
to mAAdhaTTah/babel
that referenced
this pull request
Mar 15, 2019
* master: (58 commits) Remove dependency on home-or-tmp package (babel#9678) [proposal-object-rest-spread] fix templateLiteral in extractNormalizedKeys (babel#9628) Partial application plugin (babel#9474) Private Static Class Methods (Stage 3) (babel#9446) gulp-uglify@3.0.2 rollup@1.6.0 eslint@5.15.1 jest@24.5.0 regexpu-core@4.5.4 Remove input and length from state (babel#9646) Switch from rollup-stream to rollup and update deps (babel#9640) System modules - Hoist classes like other variables (babel#9639) fix: Don't transpile ES2018 symbol properties (babel#9650) Add WarningsToErrorsPlugin to webpack to avoid missing build problems on CI (babel#9647) Update regexpu-core dependency (babel#9642) Add placeholders support to @babel/types and @babel/generator (babel#9542) Generate plugins file Make babel-standalone an ESModule and enable flow (babel#9025) Reorganize token types and use a map for them (babel#9645) [TS] Allow context type annotation on getters/setters (babel#9641) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @robpalme @nicolo-ribaudo @littledan