Skip to content

Add WarningsToErrorsPlugin to webpack to avoid missing build problems on CI#9647

Merged
danez merged 1 commit intobabel:masterfrom
danez:warning-to-error
Mar 7, 2019
Merged

Add WarningsToErrorsPlugin to webpack to avoid missing build problems on CI#9647
danez merged 1 commit intobabel:masterfrom
danez:warning-to-error

Conversation

@danez
Copy link
Member

@danez danez commented Mar 7, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix? n
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This should break the build if there are warnings in the webpack build, which we currently have because of #9636
Let's see.

@danez danez added the PR: Internal 🏠 A type of pull request used for our changelog categories label Mar 7, 2019
@babel-bot
Copy link
Collaborator

babel-bot commented Mar 7, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10431/

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10426/

@nicolo-ribaudo
Copy link
Member

It is fixed by #9642, right?

@danez
Copy link
Member Author

danez commented Mar 7, 2019

Yes

@danez danez merged commit b2b96e0 into babel:master Mar 7, 2019
@danez danez deleted the warning-to-error branch March 7, 2019 23:44
mAAdhaTTah added a commit to mAAdhaTTah/babel that referenced this pull request Mar 15, 2019
* master: (58 commits)
  Remove dependency on home-or-tmp package (babel#9678)
  [proposal-object-rest-spread] fix templateLiteral in extractNormalizedKeys (babel#9628)
  Partial application plugin (babel#9474)
  Private Static Class Methods (Stage 3) (babel#9446)
  gulp-uglify@3.0.2
  rollup@1.6.0
  eslint@5.15.1
  jest@24.5.0
  regexpu-core@4.5.4
  Remove input and length from state (babel#9646)
  Switch from rollup-stream to rollup and update deps (babel#9640)
  System modules - Hoist classes like other variables (babel#9639)
  fix: Don't transpile ES2018 symbol properties (babel#9650)
  Add WarningsToErrorsPlugin to webpack to avoid missing build problems on CI (babel#9647)
  Update regexpu-core dependency (babel#9642)
  Add placeholders support to @babel/types and @babel/generator (babel#9542)
  Generate plugins file
  Make babel-standalone an ESModule and enable flow (babel#9025)
  Reorganize token types and use a map for them (babel#9645)
  [TS] Allow context type annotation on getters/setters (babel#9641)
  ...
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants