Make babel-standalone an ESModule and enable flow#9025
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10391/ |
| @@ -0,0 +1,244 @@ | |||
| // @flow | |||
| export { default as externalHelpers } from "@babel/plugin-external-helpers"; | |||
There was a problem hiding this comment.
Is it possible to auto-generate this file and the list in packages/babel-standalone/src/index.js?
There was a problem hiding this comment.
Note that we shouldn't generate it from the list of the directories but we still need to maintain a list of included plugins (which wouldn't be duplicated anymore).
|
Looks good. I like the flow types. Out of curiosity could those land separately? |
|
Okay I finally added the autogeneration. |
| @@ -0,0 +1,87 @@ | |||
| { | |||
| "all": [ | |||
There was a problem hiding this comment.
Can't this file just be the array?
There was a problem hiding this comment.
Oh yes. I first had more keys in there, as I wanted to also specify which plugins go to which preset, but that does not work because of plugin options and other business logic.
Will revert.
|
The failing status of this PR is just because the hack I used to create the publish github action without support for "release" events in publis repos has some problems when PRs are opened from branches of this repo. |
* master: (58 commits) Remove dependency on home-or-tmp package (babel#9678) [proposal-object-rest-spread] fix templateLiteral in extractNormalizedKeys (babel#9628) Partial application plugin (babel#9474) Private Static Class Methods (Stage 3) (babel#9446) gulp-uglify@3.0.2 rollup@1.6.0 eslint@5.15.1 jest@24.5.0 regexpu-core@4.5.4 Remove input and length from state (babel#9646) Switch from rollup-stream to rollup and update deps (babel#9640) System modules - Hoist classes like other variables (babel#9639) fix: Don't transpile ES2018 symbol properties (babel#9650) Add WarningsToErrorsPlugin to webpack to avoid missing build problems on CI (babel#9647) Update regexpu-core dependency (babel#9642) Add placeholders support to @babel/types and @babel/generator (babel#9542) Generate plugins file Make babel-standalone an ESModule and enable flow (babel#9025) Reorganize token types and use a map for them (babel#9645) [TS] Allow context type annotation on getters/setters (babel#9641) ...
As a requirement for #7581, but it is also not abad thing to do for webpack so treeshaking and module concatenation can work.
There also should not be any problems with circle dependencies as standalone is the entry point for webpack and is nowhere referenced.