Skip to content

Use correct "this" in static fields#9508

Merged
nicolo-ribaudo merged 1 commit intobabel:masterfrom
nicolo-ribaudo:static-field-this
Feb 24, 2019
Merged

Use correct "this" in static fields#9508
nicolo-ribaudo merged 1 commit intobabel:masterfrom
nicolo-ribaudo:static-field-this

Conversation

@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Feb 13, 2019

Q                       A
Fixed Issues? Fixes #5222
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This PR partially reverts #6158 by @jridgewell

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Class Fields labels Feb 13, 2019
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10088/

Copy link
Member

@danez danez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the issue and the added examples, it seems to do the right thing to me.

@nicolo-ribaudo nicolo-ribaudo merged commit 0b01b52 into babel:master Feb 24, 2019
@nicolo-ribaudo nicolo-ribaudo deleted the static-field-this branch February 24, 2019 07:15
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Class Fields

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transform-class-properties: Static arrow functions are bound to undefined rather than the class

4 participants