Skip to content

Class instance properties define their own context#6158

Merged
hzoo merged 1 commit intobabel:7.0from
jridgewell:class-property-arrow-this
Aug 28, 2017
Merged

Class instance properties define their own context#6158
hzoo merged 1 commit intobabel:7.0from
jridgewell:class-property-arrow-this

Conversation

@jridgewell
Copy link
Member

Ensure class instance properties have a fresh function context that's not already transformed by a parent arrow (or class).

Pending #5222, we can change this to also include static properties, too.

Fixes #6153.
Fixes #6154.

@jridgewell jridgewell added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Aug 26, 2017
@babel-bot
Copy link
Collaborator

babel-bot commented Aug 26, 2017

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/4706/

@noahlemen
Copy link
Member

noahlemen commented Aug 26, 2017

nice! looks like we even arrived at the same solution (for #6153), more or less

@hzoo hzoo merged commit ac6eda2 into babel:7.0 Aug 28, 2017
@jridgewell jridgewell deleted the class-property-arrow-this branch February 24, 2019 00:52
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Class Fields

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants