Skip to content

Add babel-generator support for Import#4945

Merged
hzoo merged 1 commit intobabel:masterfrom
TheLarkInn:feature/add_generator_import_support
Dec 7, 2016
Merged

Add babel-generator support for Import#4945
hzoo merged 1 commit intobabel:masterfrom
TheLarkInn:feature/add_generator_import_support

Conversation

@TheLarkInn
Copy link
Copy Markdown
Contributor

@TheLarkInn TheLarkInn commented Dec 5, 2016 •
edited
Loading

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? yes
Tests added/pass? yes
Fixed tickets Fixes #4944
License MIT
Doc PR no
Dependency Changes no

This adds support to the dynamic-import-syntax for babel-generator and babel-types.

@hzoo hzoo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: generator labels Dec 5, 2016
@jamiebuilds
Copy link
Copy Markdown
Contributor

jamiebuilds commented Dec 5, 2016

We need a more specific node name than this, what is used in the spec?

@hzoo
Copy link
Copy Markdown
Member

hzoo commented Dec 5, 2016 •
edited
Loading

@thejameskyle (this is only because we already added Import as the node type name before), and I think the thinking was that it was similar to Super

So unfortunately will need to make a major version for changes to it

ImportCall, ImportCallExpression, DynamicImport? Again it's similar to Super though

@hzoo
Copy link
Copy Markdown
Member

hzoo commented Dec 5, 2016 •
edited
Loading

Ref babel/babylon#163, estree/estree#137, https://github.com/tc39/proposal-dynamic-import cc @domenic @kesne

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 5, 2016 •
edited
Loading

Current coverage is 89.22% (diff: 100%)

No coverage report found for master at b81cf12.

Powered by Codecov. Last update b81cf12...7c1f838

@hzoo hzoo changed the title Add generator support for Import Add babel-generator support for Import Dec 5, 2016
@hzoo hzoo merged commit 39c9216 into babel:master Dec 7, 2016
@TheLarkInn TheLarkInn deleted the feature/add_generator_import_support branch December 8, 2016 00:11
Jessidhia pushed a commit to Jessidhia/babel that referenced this pull request Dec 8, 2016
Merge branch 'master' into modules-commonjs-spec
f15b506 
* master:
  update `regenerator-runtime` in `babel-polypill` (babel#4966)
  Temp fix for make watch [skip ci] (babel#4967)
  Add (and fix) failing test of function parameter bindings in a catch block (babel#4880)
  Upgrade regenerator-runtime to version 0.10.0. (babel#4877)
  Add `/.test` and `/src` to `babel-plugin-transform-regenerator` `.npmignore`. (babel#4961) [skip ci]
  Only base async fn arity on non-default/non-rest params - fixes babel#4891 (babel#4901)
  Add generator support for Import (babel#4945)
panagosg7 pushed a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
@TheLarkInn @panagosg7
Add generator support for Import (babel#4945)
9a911c2
@hzoo hzoo mentioned this pull request Jan 25, 2017
Merged
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hzoo hzoo hzoo approved these changes

+1 more reviewer

@danez danez danez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generator Support missing for [dynamic] Import

5 participants

@TheLarkInn @jamiebuilds @hzoo @codecov-io @danez