Upgrade regenerator-runtime to version 0.10.0#4877
Merged
hzoo merged 1 commit intobabel:masterfrom Dec 8, 2016
Merged
Conversation
This changes the behavior of `runtime.awrap` to match the output of https://github.com/leebyron/async-to-gen. See this commit for further explanation of why this change is a good idea: facebook/regenerator@e62a7e5
Current coverage is 89.35% (diff: 100%)@@ master #4877 diff @@
==========================================
Files 196 196
Lines 14020 14020
Methods 1460 1460
Messages 0 0
Branches 3262 3262
==========================================
Hits 12528 12528
Misses 1492 1492
Partials 0 0
|
Member
|
Thanks @benjamn! |
Member
|
The same required for |
Jessidhia
pushed a commit
to Jessidhia/babel
that referenced
this pull request
Dec 8, 2016
* master: update `regenerator-runtime` in `babel-polypill` (babel#4966) Temp fix for make watch [skip ci] (babel#4967) Add (and fix) failing test of function parameter bindings in a catch block (babel#4880) Upgrade regenerator-runtime to version 0.10.0. (babel#4877) Add `/.test` and `/src` to `babel-plugin-transform-regenerator` `.npmignore`. (babel#4961) [skip ci] Only base async fn arity on non-default/non-rest params - fixes babel#4891 (babel#4901) Add generator support for Import (babel#4945)
panagosg7
pushed a commit
to panagosg7/babel
that referenced
this pull request
Jan 17, 2017
This changes the behavior of `runtime.awrap` to match the output of https://github.com/leebyron/async-to-gen. See this commit for further explanation of why this change is a good idea: facebook/regenerator@e62a7e5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the behavior of
regeneratorRuntime.awrapto avoid potential problems withinstanceof, and to match the output of https://github.com/leebyron/async-to-gen. This could, in the future, allow that library to use theregenerator-runtimeimplementation ofAsyncIterator, but that's not urgent. Either way, it seems best for different implementations to follow the same conventions for runtime behavior.See this commit for further explanation of why this change is a good idea: facebook/regenerator@e62a7e5