Skip to content

Only base async fn arity on non-default/non-rest params - fixes #4891#4901

Merged
hzoo merged 1 commit intobabel:masterfrom
loganfsmyth:async-fn-arity-4891
Dec 8, 2016
Merged

Only base async fn arity on non-default/non-rest params - fixes #4891#4901
hzoo merged 1 commit intobabel:masterfrom
loganfsmyth:async-fn-arity-4891

Conversation

@loganfsmyth
Copy link
Copy Markdown
Member

@loganfsmyth loganfsmyth commented Nov 28, 2016

Q A
Bug fix? Y
Breaking change? N
New feature?
Deprecations?
Spec compliancy?
Tests added/pass?
Fixed tickets Fixes #4891
License MIT
Doc PR
Dependency Changes

Only add params up to the first non-idenfier param.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 28, 2016

Current coverage is 89.35% (diff: 100%)

Merging #4901 into master will increase coverage by <.01%

@@             master      #4901   diff @@
==========================================
  Files           196        196          
  Lines         14022      14025     +3   
  Methods        1460       1460          
  Messages          0          0          
  Branches       3263       3265     +2   
==========================================
+ Hits          12529      12532     +3   
  Misses         1493       1493          
  Partials          0          0          

Powered by Codecov. Last update 1d9e509...d9c6db5

@existentialism existentialism added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Dec 1, 2016
@hzoo hzoo merged commit 80dfdd2 into babel:master Dec 8, 2016
Jessidhia pushed a commit to Jessidhia/babel that referenced this pull request Dec 8, 2016
* master:
  update `regenerator-runtime` in `babel-polypill` (babel#4966)
  Temp fix for make watch [skip ci] (babel#4967)
  Add (and fix) failing test of function parameter bindings in a catch block (babel#4880)
  Upgrade regenerator-runtime to version 0.10.0. (babel#4877)
  Add `/.test` and `/src` to `babel-plugin-transform-regenerator` `.npmignore`. (babel#4961) [skip ci]
  Only base async fn arity on non-default/non-rest params - fixes babel#4891 (babel#4901)
  Add generator support for Import (babel#4945)
@loganfsmyth loganfsmyth deleted the async-fn-arity-4891 branch December 8, 2016 22:12
panagosg7 pushed a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

length property of function changes when declared async

4 participants