Skip to content

Fix OPENSSL_memchr per C23#3008

Merged
justsmth merged 1 commit intoaws:mainfrom
justsmth:fix-memchr
Feb 19, 2026
Merged

Fix OPENSSL_memchr per C23#3008
justsmth merged 1 commit intoaws:mainfrom
justsmth:fix-memchr

Conversation

@justsmth
Copy link
Copy Markdown
Contributor

@justsmth justsmth commented Feb 18, 2026

Issues:

Resolves #2995

Description of changes:

C23 makes memchr const-correct, returning const void * when the input is const void *. Some C libraries (e.g. glibc 2.41+) apply this change even in C11 mode. This causes a -Wdiscarded-qualifiers error in the C code path of OPENSSL_memchr, which returns void *. Combined with -Werror, this breaks the build on distributions like Arch Linux that ship these newer toolchains.

Also guard the -Wno-c11-extensions flag behind a Clang check, as it is Clang-specific and produces a diagnostic note on GCC.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.31%. Comparing base (110f184) to head (e9214f5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3008   +/-   ##
=======================================
  Coverage   78.31%   78.31%           
=======================================
  Files         689      689           
  Lines      120995   120995           
  Branches    16971    16973    +2     
=======================================
+ Hits        94758    94762    +4     
+ Misses      25341    25337    -4     
  Partials      896      896           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth merged commit 390b9c0 into aws:main Feb 19, 2026
541 of 551 checks passed
@justsmth justsmth deleted the fix-memchr branch February 19, 2026 19:08
@justsmth justsmth mentioned this pull request Feb 20, 2026
justsmth added a commit that referenced this pull request Feb 20, 2026
### Description of changes: 
* Bump urllib3 from 2.6.0 to 2.6.3 in /tests/ci by @dependabot[bot] in
#2932
* Add weekly automated check for outdated third-party test vectors by
@sgmenda in #2933
* Enable Hybrid PQ KeyShares by default by @alexw91 in
#2531
* Remove AVX conditional from cmake script by @torben-hansen in
#2958
* openssl-ca command implementation for self-sign certificates by
@skmcgrail in #2937
* Initial Framework for Using Doxygen to Document Public Header Files by
@m271828 in #2908
* Move md4 out of FIPS module by @torben-hansen in
#2956
* Fix image-build-windows workflow to only push on workflow_call and
workflow_dispatch by @skmcgrail in
#2961
* Remove FIPS counter framework and other tidying up by @torben-hansen
in #2947
* Model Device Farm CI Resources in CDK by @skmcgrail in
#2965
* Adds a new randomness generation API by @torben-hansen in
#2963
* Migrate Android Testing to GitHub Actions by @skmcgrail in
#2969
* Ensure pkcs7 checks ASN1_TYPE->type by @skmcgrail in
#2968
* Fix checkout logic for android-omnibus by @skmcgrail in
#2970
* Add missing env vars to check-vectors workflow step by @sgmenda in
#2962
* Shorten Windows Build Directory Path by @skmcgrail in
#2974
* Bump mysql cluster version by @WillChilds-Klein in
#2967
* Integrate Wycheproof ML-DSA test vectors by @sgmenda in
#2973
* Simplify FIPS conditional in top-level build script by @torben-hansen
in #2976
* Fix aws-lc-rs CI job by @justsmth in
#2966
* Add method to get type of ML-DSA instance configured under EVP PKEY by
@torben-hansen in #2980
* Nmap build needs liblinear by @justsmth in
#2985
* Disable SLP vectorizer for FIPS shared library builds on GCC 14+ by
@geedo0 in #2977
* Update Wycheproof ECDSA test vectors and fix workflow typo by @sgmenda
in #2972
* Address some CMake findings by @skmcgrail in
#2979
* Bump bytes from 1.7.1 to 1.11.1 in /tests/ci/lambda by
@dependabot[bot] in #2983
* Support GCC 4.8 for aarch64 by @justsmth in
#2964
* Free potential memory before assigning new pointer by @torben-hansen
in #2989
* Add PyOpenSSL integration test by @WillChilds-Klein in
#2992
* Ensure index argument is not negative in ASN1_BIT_STRING_set_bit by
@torben-hansen in #2987
* Ensure no overflow in signed output length in do_buf by @torben-hansen
in #2988
* Remove redundant CPython 3.9 integration test by @WillChilds-Klein in
#2996
* Ensure public key is set before verifying through ML-DSA verify by
@torben-hansen in #2990
* Correct CCM nids in object definition by @torben-hansen in
#2991
* Address Reported Bug Findings by @skmcgrail in
#3000
* Fix CI: gcc-4.8 by @justsmth in
#3011
* Fix Windows CI: use `cd /d` in run_windows_tests.bat to handle
cross-drive paths by @justsmth in
#3012
* Fix OPENSSL_memchr per C23 by @justsmth in
#3008
* Fix argument order in `hmac_copy` by @justsmth in
#3014
* Miscellaneous CI improvements by @skmcgrail in
#2978
* Fix CI: mariadb by @justsmth in
#3015
* Update Ubuntu 24:04 image compiler verification by @skmcgrail in
#3017
* Support WASM/Emscripten by @justsmth in
#2959
* Generate Rust Bindings by @justsmth in
#2999

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
gasmith added a commit to foxglove/foxglove-sdk that referenced this pull request Mar 4, 2026
gasmith added a commit to foxglove/foxglove-sdk that referenced this pull request Mar 4, 2026
### Changelog
None

### Docs
None

### Description
Pull in this upstream fix: aws/aws-lc#3008
gasmith added a commit to foxglove/foxglove-sdk that referenced this pull request Mar 4, 2026
kou added a commit to kou/arrow that referenced this pull request Mar 27, 2026
aws-lc can't be built with C23:
aws/aws-lc#2995

It's fixed in upstream:
aws/aws-lc#3008
kou added a commit to kou/arrow that referenced this pull request Mar 27, 2026
aws-lc can't be built with C23:
aws/aws-lc#2995

It's fixed in upstream:
aws/aws-lc#3008
kou added a commit to apache/arrow that referenced this pull request Mar 28, 2026
### Rationale for this change

aws-lc can't be built with C23:
aws/aws-lc#2995

It's fixed in upstream:
aws/aws-lc#3008

### What changes are included in this PR?

Update bundled AWS SDK C++ related products to the latest version.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* GitHub Issue: #49601

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fails to build on Arch Linux without -Wno-discarded-qualifiers

5 participants