Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2999 +/- ##
==========================================
+ Coverage 78.31% 78.32% +0.01%
==========================================
Files 689 689
Lines 121007 121007
Branches 16996 16995 -1
==========================================
+ Hits 94765 94782 +17
+ Misses 25346 25329 -17
Partials 896 896 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2691858 to
4697f35
Compare
1f10f83 to
ad3602a
Compare
1dc5208 to
a262385
Compare
Use bindgen's --raw-line to add #![allow(...)] directives directly to the generated bindings file, so consumers don't need to suppress warnings themselves. Covers the standard bindgen warnings (naming conventions, dead_code, improper_ctypes, clippy) plus unpredictable_function_pointer_comparisons which is triggered by deriving PartialEq on structs with function pointer fields. Remove the now-redundant #![allow(...)] lines from the CI compile-check test.
samuel40791765
approved these changes
Feb 19, 2026
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - os: ubuntu-latest |
Contributor
There was a problem hiding this comment.
Nit: Seeing that this is part of a work to flip everything internally, do we need to test on AL2023 or AL2?
This was referenced Feb 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Description of changes:
This adds CMake support for generating Rust FFI bindings from the AWS-LC public C headers using
bindgen-cli. This is intended for use by downstream Rust consumers so that bindings can be generated directly from the CMake build system.New CMake option:
-DGENERATE_RUST_BINDINGS=ON(off by default)When enabled, the build:
bindgen-cli(≥0.69.5) andrustfmtare availablerust_wrapper.haggregation headerbindgento produceaws_lc_bindings.rsin the build directoryBORINGSSL_PREFIXmechanism — uses--prefix-link-nameso Rust-side function names stay unprefixed while#[link_name]attributes carry the prefix for the linker$INSTALL_DIR/share/rust/aws_lc_bindings.rsFiles added:
cmake/rust_bindings.cmake— Module containing the header discovery, prefix formatting, and bindgen invocation logiccmake/rust_wrapper.h.in— Template header that aggregates all public headers for bindgen inputCall-outs:
boringssl_prefix_symbols.h) is intentionally excluded from bindgen's input. The rationale is documented in the module-level comment incmake/rust_bindings.cmake.rust_bindingstarget is not part ofALL. It is built on-demand when explicitly requested (--target rust_bindings) or automatically duringcmake --install.get_symbol_prefix_format().Testing:
CI workflow added in
.github/workflows/aws-lc-rs.yml(cmake-rust-bindingsjob) covering:BORINGSSL_PREFIX=AWSLCBORINGSSL_PREFIX=AWSLCEach matrix entry verifies that bindings are generated, contain expected symbols, have correct prefix behavior, and compile as valid Rust.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.