Add PyOpenSSL integration test#2992
Merged
WillChilds-Klein merged 10 commits intoaws:mainfrom Feb 13, 2026
Merged
Conversation
a70a077 to
034fd86
Compare
034fd86 to
f0bf6e5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2992 +/- ##
==========================================
- Coverage 78.31% 78.31% -0.01%
==========================================
Files 689 689
Lines 120967 120967
Branches 16963 16963
==========================================
- Hits 94735 94734 -1
- Misses 25334 25338 +4
+ Partials 898 895 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
reviewed
Feb 13, 2026
justsmth
reviewed
Feb 13, 2026
| # against AWS-LC. | ||
| curl https://sh.rustup.rs -sSf | sh -s -- -y | ||
| . "$HOME/.cargo/env" | ||
| cargo install bindgen-cli |
Contributor
There was a problem hiding this comment.
Do we know bindgen-cli is needed?
Contributor
Author
There was a problem hiding this comment.
i'd thought it was required to build the Cryptography module against aws-lc/aws-lc-rs, but i can try removing this install.
Contributor
Author
There was a problem hiding this comment.
yeah, looks like it's needed.
thread 'main' (3513) panicked at /root/.cache/puccinialin/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/openssl-sys-0.9.110/build/run_bindgen.rs:341:39:
bindgen failed to execute: Os { code: 2, kind: NotFound, message: "No such file or directory" }
…' into cache-peer-ca-names
This reverts commit df129b2.
justsmth
approved these changes
Feb 13, 2026
torben-hansen
approved these changes
Feb 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
This PR adds an integration test against PyOpenSSL's tip-of-main, as well as a patch file to work around a few present incompatibilities.
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.