Skip to content

Set correct livenessProbe success threshold#548

Merged
ezodude merged 2 commits intolabels-to-extensionfrom
es-success-threshold-544
Jun 2, 2021
Merged

Set correct livenessProbe success threshold#548
ezodude merged 2 commits intolabels-to-extensionfrom
es-success-threshold-544

Conversation

@ezodude
Copy link
Contributor

@ezodude ezodude commented Jun 1, 2021

Resolves #544

  • Introduces success threshold config for a v1Probe.
  • Ensures the LivenessProbe success threshold is always set to 1.

@ezodude ezodude requested a review from marcinc June 1, 2021 09:55
@ezodude ezodude requested a review from marcinc June 2, 2021 05:40
Copy link
Member

@marcinc marcinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ezodude ezodude merged commit 53d0410 into labels-to-extension Jun 2, 2021
@ezodude ezodude deleted the es-success-threshold-544 branch June 2, 2021 21:55
ezodude added a commit that referenced this pull request Jun 4, 2021
* add extension support (#432)

* add extension support

* add extensions to init (#439)

* kev-449 overlay validation (#451)

* kev-458 Render probe info from extensions (#459)

* Latest from master.

* kev-458 remove label validation (#482)

* kev-458 remove label validation

* Kev 458 cleanup moved extensions (#483)

* kev-458 cleanup moved extensions

* remove unused code

* kev-458 move imagepull labels (#498)

* kev-458 move resource (#499)

* kev-458 move cpu (#500)

* Bug fix - can now use correct workload type during init and render. (#504)

* Extract volume settings into a volumes K8s extension (#502)

* Enable volumes reconciliation for extensions. (#506)

* Render volumes using extension settings (#508)

* Remove volume labels use (#509)

* Moved the autoscale labels to extensions. (#514)

* Move the pod-security labels to extensions. (#516)

* Move the rolling update max surge and service account name to extensions. (#519)

* Move the service labels to extensions (#521)

* Remove services labels use. (#525)

* Turn Restart Policy string value sets into enums (#533)

* Turn Workload Type and Service Type value sets into enums (#534)

* Minify Extensions (#536)

* Set correct livenessProbe success threshold (#548)

* Update the documentation to use extensions instead of labels. (#547)

* Handle ingress with kubernetes cluster defaults (#552)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants