Turn Restart Policy string value sets into enums#533
Merged
ezodude merged 5 commits intolabels-to-extensionfrom May 21, 2021
Merged
Turn Restart Policy string value sets into enums#533ezodude merged 5 commits intolabels-to-extensionfrom
ezodude merged 5 commits intolabels-to-extensionfrom
Conversation
marcinc
reviewed
May 20, 2021
Member
marcinc
left a comment
There was a problem hiding this comment.
A few comments. LGTMO. Also, liking the tweaks and cleanup to the test coverage 👍
pkg/kev/testdata/init-default/docker-compose-yml/docker-compose.yml
Outdated
Show resolved
Hide resolved
- Restart policy deploy value overrides restart value. - Ensured the rendered restart policy is case sensitive so not to break the generated k8s manifests.
ezodude
added a commit
that referenced
this pull request
May 27, 2021
ezodude
added a commit
that referenced
this pull request
Jun 4, 2021
ezodude
added a commit
that referenced
this pull request
Jun 4, 2021
* add extension support (#432) * add extension support * add extensions to init (#439) * kev-449 overlay validation (#451) * kev-458 Render probe info from extensions (#459) * Latest from master. * kev-458 remove label validation (#482) * kev-458 remove label validation * Kev 458 cleanup moved extensions (#483) * kev-458 cleanup moved extensions * remove unused code * kev-458 move imagepull labels (#498) * kev-458 move resource (#499) * kev-458 move cpu (#500) * Bug fix - can now use correct workload type during init and render. (#504) * Extract volume settings into a volumes K8s extension (#502) * Enable volumes reconciliation for extensions. (#506) * Render volumes using extension settings (#508) * Remove volume labels use (#509) * Moved the autoscale labels to extensions. (#514) * Move the pod-security labels to extensions. (#516) * Move the rolling update max surge and service account name to extensions. (#519) * Move the service labels to extensions (#521) * Remove services labels use. (#525) * Turn Restart Policy string value sets into enums (#533) * Turn Workload Type and Service Type value sets into enums (#534) * Minify Extensions (#536) * Set correct livenessProbe success threshold (#548) * Update the documentation to use extensions instead of labels. (#547) * Handle ingress with kubernetes cluster defaults (#552)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #493