Skip to content

kev-449 overlay validation#451

Merged
mangas merged 1 commit intomasterfrom
kev-449-overly-validation
Apr 13, 2021
Merged

kev-449 overlay validation#451
mangas merged 1 commit intomasterfrom
kev-449-overly-validation

Conversation

@mangas
Copy link
Contributor

@mangas mangas commented Apr 7, 2021

closes #449

Copy link
Member

@marcinc marcinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A first pass with few comments & questions

@mangas mangas force-pushed the kev-449-overly-validation branch from e376acf to 7f4d40d Compare April 9, 2021 17:25
@mangas mangas marked this pull request as ready for review April 9, 2021 17:25
Copy link
Member

@marcinc marcinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few more comments.

@marcinc marcinc self-requested a review April 13, 2021 09:53
marcinc
marcinc previously approved these changes Apr 13, 2021
Copy link
Member

@marcinc marcinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@marcinc marcinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mangas mangas merged commit c6c4ec0 into master Apr 13, 2021
@mangas mangas deleted the kev-449-overly-validation branch April 13, 2021 10:32
@ezodude ezodude requested a review from marcinc April 13, 2021 10:32
marcinc pushed a commit that referenced this pull request Apr 19, 2021
marcinc added a commit that referenced this pull request Apr 19, 2021
marcinc added a commit that referenced this pull request Apr 20, 2021
* Revert "kev-458 Render probe info from extensions (#459)"

This reverts commit 7cfd284.

* Revert "kev-449 overlay validation (#451)"

This reverts commit c6c4ec0.

* Revert "add extensions to init (#439)"

This reverts commit 539480d.

* Revert "add extension support (#432)"

This reverts commit d694204.

Co-authored-by: marcinc <marcin.ciszak@appvia.io>
marcinc pushed a commit that referenced this pull request Apr 20, 2021
marcinc pushed a commit that referenced this pull request Apr 22, 2021
marcinc pushed a commit that referenced this pull request Apr 22, 2021
ezodude pushed a commit that referenced this pull request May 27, 2021
ezodude pushed a commit that referenced this pull request Jun 4, 2021
ezodude added a commit that referenced this pull request Jun 4, 2021
* add extension support (#432)

* add extension support

* add extensions to init (#439)

* kev-449 overlay validation (#451)

* kev-458 Render probe info from extensions (#459)

* Latest from master.

* kev-458 remove label validation (#482)

* kev-458 remove label validation

* Kev 458 cleanup moved extensions (#483)

* kev-458 cleanup moved extensions

* remove unused code

* kev-458 move imagepull labels (#498)

* kev-458 move resource (#499)

* kev-458 move cpu (#500)

* Bug fix - can now use correct workload type during init and render. (#504)

* Extract volume settings into a volumes K8s extension (#502)

* Enable volumes reconciliation for extensions. (#506)

* Render volumes using extension settings (#508)

* Remove volume labels use (#509)

* Moved the autoscale labels to extensions. (#514)

* Move the pod-security labels to extensions. (#516)

* Move the rolling update max surge and service account name to extensions. (#519)

* Move the service labels to extensions (#521)

* Remove services labels use. (#525)

* Turn Restart Policy string value sets into enums (#533)

* Turn Workload Type and Service Type value sets into enums (#534)

* Minify Extensions (#536)

* Set correct livenessProbe success threshold (#548)

* Update the documentation to use extensions instead of labels. (#547)

* Handle ingress with kubernetes cluster defaults (#552)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ensure overlay gets updated and merged with base during render

2 participants