Conversation
f9d0f6f to
d375474
Compare
marcinc
reviewed
Apr 1, 2021
| type: Deployment | ||
| replicas: 1 | ||
| livenessProbe: | ||
| type: exec |
Member
There was a problem hiding this comment.
I appreciate it may not be in scope of this PR, but something we should consider.
Instead of specifying the probe type we could just use it as a key with nested configuration specific to selected probe type, see example in #443.
livenessProbe:
exec:
command: "your command"
...
readinessProbe:
http:
port: 8080
path: /
...
readinessProbe:
tcp:
port: 8080
...The only challenge with the above is a none probe type... but perhaps we could work on assumption that if none type was intended, then the probe shouldn't be present in the configuration at all?
Contributor
Author
There was a problem hiding this comment.
I'd rather table this for now and discuss this as a separate issue. This causes a bit of problems because many of them can be filled and so we end up with more errors and making it really hard for someone to switch between types because they would need to remove all the alternatives or risk them being used on the k8s config. Not sure if that produces an error or not. Either case I think this is better as a ticket to be discussed, what do you think?
marcinc
approved these changes
Apr 6, 2021
marcinc
added a commit
that referenced
this pull request
Apr 19, 2021
Co-authored-by: Marcin Ciszak <marcinc@users.noreply.github.com>
marcinc
added a commit
that referenced
this pull request
Apr 20, 2021
* Revert "kev-458 Render probe info from extensions (#459)" This reverts commit 7cfd284. * Revert "kev-449 overlay validation (#451)" This reverts commit c6c4ec0. * Revert "add extensions to init (#439)" This reverts commit 539480d. * Revert "add extension support (#432)" This reverts commit d694204. Co-authored-by: marcinc <marcin.ciszak@appvia.io>
marcinc
added a commit
that referenced
this pull request
Apr 20, 2021
Co-authored-by: Marcin Ciszak <marcinc@users.noreply.github.com>
marcinc
added a commit
that referenced
this pull request
Apr 22, 2021
Co-authored-by: Marcin Ciszak <marcinc@users.noreply.github.com>
marcinc
added a commit
that referenced
this pull request
Apr 22, 2021
Co-authored-by: Marcin Ciszak <marcinc@users.noreply.github.com>
ezodude
pushed a commit
that referenced
this pull request
May 27, 2021
Co-authored-by: Marcin Ciszak <marcinc@users.noreply.github.com>
ezodude
pushed a commit
that referenced
this pull request
Jun 4, 2021
Co-authored-by: Marcin Ciszak <marcinc@users.noreply.github.com>
ezodude
added a commit
that referenced
this pull request
Jun 4, 2021
* add extension support (#432) * add extension support * add extensions to init (#439) * kev-449 overlay validation (#451) * kev-458 Render probe info from extensions (#459) * Latest from master. * kev-458 remove label validation (#482) * kev-458 remove label validation * Kev 458 cleanup moved extensions (#483) * kev-458 cleanup moved extensions * remove unused code * kev-458 move imagepull labels (#498) * kev-458 move resource (#499) * kev-458 move cpu (#500) * Bug fix - can now use correct workload type during init and render. (#504) * Extract volume settings into a volumes K8s extension (#502) * Enable volumes reconciliation for extensions. (#506) * Render volumes using extension settings (#508) * Remove volume labels use (#509) * Moved the autoscale labels to extensions. (#514) * Move the pod-security labels to extensions. (#516) * Move the rolling update max surge and service account name to extensions. (#519) * Move the service labels to extensions (#521) * Remove services labels use. (#525) * Turn Restart Policy string value sets into enums (#533) * Turn Workload Type and Service Type value sets into enums (#534) * Minify Extensions (#536) * Set correct livenessProbe success threshold (#548) * Update the documentation to use extensions instead of labels. (#547) * Handle ingress with kubernetes cluster defaults (#552)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #438