MINOR: Remove workarounds for lz4-java bug affecting byte buffers#6679
Merged
Conversation
lz4/lz4-java#65 was part of lz4-java 1.4.0.
Member
Author
|
cc @xvrl |
1634b8c to
4c4048a
Compare
xvrl
approved these changes
May 5, 2019
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
May 8, 2019
…s-hashcode * apache-github/trunk: KAFKA-8158: Add EntityType for Kafka RPC fields (apache#6503) MINOR: correctly parse version OffsetCommitResponse version < 3 KAFKA-8284: enable static membership on KStream (apache#6673) KAFKA-8304: Fix registration of Connect REST extensions (apache#6651) KAFKA-8275; Take throttling into account when choosing least loaded node (apache#6619) KAFKA-3522: Interactive Queries must return timestamped stores (apache#6661) MINOR: MetricsIntegrationTest should set StreamsConfig.STATE_DIR_CONFIG (apache#6687) MINOR: Remove unused field in `ListenerConnectionQuota` KAFKA-8131; Move --version implementation into CommandLineUtils (apache#6481) KAFKA-8056; Use automatic RPC generation for FindCoordinator (apache#6408) MINOR: Remove workarounds for lz4-java bug affecting byte buffers (apache#6679) KAFKA-7455: Support JmxTool to connect to a secured RMI port. (apache#5968) MINOR: Document improvement (apache#6682) MINOR: Fix ThrottledReplicaListValidator doc error. (apache#6537) KAFKA-8306; Initialize log end offset accurately when start offset is non-zero (apache#6652)
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…ache#6679) lz4/lz4-java#65 was included in lz4-java 1.4.0. Relying on existing tests for verification. Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Nov 21, 2019
…fers (apache#6679)" This reverts commit 90043d5.
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Nov 30, 2019
…fers (apache#6679)" This reverts commit 90043d5.
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Dec 3, 2019
…ing byte buffers (apache#6679)" This reverts commit 90043d5 as it caused a regression in some cases: Caused by: java.io.IOException: Stream frame descriptor corrupted at org.apache.kafka.common.record.KafkaLZ4BlockInputStream.readHeader(KafkaLZ4BlockInputStream.java:132) at org.apache.kafka.common.record.KafkaLZ4BlockInputStream.<init>(KafkaLZ4BlockInputStream.java:78) at org.apache.kafka.common.record.CompressionType$4.wrapForInput(CompressionType.java:110) I will investigate why after, but I want to get the safe fix into 2.4.0.
ijuma
added a commit
that referenced
this pull request
Dec 3, 2019
…ing byte buffers (#6679)" (#7769) This reverts commit 90043d5 as it caused a regression in some cases: > Caused by: java.io.IOException: Stream frame descriptor corrupted > at org.apache.kafka.common.record.KafkaLZ4BlockInputStream.readHeader(KafkaLZ4BlockInputStream.java:132) > at org.apache.kafka.common.record.KafkaLZ4BlockInputStream.<init>(KafkaLZ4BlockInputStream.java:78) > at org.apache.kafka.common.record.CompressionType$4.wrapForInput(CompressionType.java:110) I will investigate why after, but I want to get the safe fix into 2.4.0. The reporter of KAFKA-9203 has verified that reverting this change makes the problem go away. Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
ijuma
added a commit
that referenced
this pull request
Dec 3, 2019
…ing byte buffers (#6679)" (#7769) This reverts commit 90043d5 as it caused a regression in some cases: > Caused by: java.io.IOException: Stream frame descriptor corrupted > at org.apache.kafka.common.record.KafkaLZ4BlockInputStream.readHeader(KafkaLZ4BlockInputStream.java:132) > at org.apache.kafka.common.record.KafkaLZ4BlockInputStream.<init>(KafkaLZ4BlockInputStream.java:78) > at org.apache.kafka.common.record.CompressionType$4.wrapForInput(CompressionType.java:110) I will investigate why after, but I want to get the safe fix into 2.4.0. The reporter of KAFKA-9203 has verified that reverting this change makes the problem go away. Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
ijuma
added a commit
that referenced
this pull request
Dec 3, 2019
…ing byte buffers (#6679)" (#7769) This reverts commit 90043d5 as it caused a regression in some cases: > Caused by: java.io.IOException: Stream frame descriptor corrupted > at org.apache.kafka.common.record.KafkaLZ4BlockInputStream.readHeader(KafkaLZ4BlockInputStream.java:132) > at org.apache.kafka.common.record.KafkaLZ4BlockInputStream.<init>(KafkaLZ4BlockInputStream.java:78) > at org.apache.kafka.common.record.CompressionType$4.wrapForInput(CompressionType.java:110) I will investigate why after, but I want to get the safe fix into 2.4.0. The reporter of KAFKA-9203 has verified that reverting this change makes the problem go away. Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
xiowu0
pushed a commit
to xiowu0/kafka
that referenced
this pull request
Jun 3, 2020
…nds for lz4-java bug affecting byte buffers (apache#6679)" (apache#7769) TICKET = KAFKA-9203 LI_DESCRIPTION = EXIT_CRITERIA = HASH [f8129f6] ORIGINAL_DESCRIPTION = This reverts commit 90043d5 as it caused a regression in some cases: > Caused by: java.io.IOException: Stream frame descriptor corrupted > at org.apache.kafka.common.record.KafkaLZ4BlockInputStream.readHeader(KafkaLZ4BlockInputStream.java:132) > at org.apache.kafka.common.record.KafkaLZ4BlockInputStream.<init>(KafkaLZ4BlockInputStream.java:78) > at org.apache.kafka.common.record.CompressionType$4.wrapForInput(CompressionType.java:110) I will investigate why after, but I want to get the safe fix into 2.4.0. The reporter of KAFKA-9203 has verified that reverting this change makes the problem go away. Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com> (cherry picked from commit f8129f6)
xiowu0
added a commit
to linkedin/kafka
that referenced
this pull request
Jun 3, 2020
…nds for lz4-java bug affecting byte buffers (apache#6679)" (apache#7769) (#84) TICKET = KAFKA-9203 LI_DESCRIPTION = EXIT_CRITERIA = HASH [f8129f6] ORIGINAL_DESCRIPTION = This reverts commit 90043d5 as it caused a regression in some cases: > Caused by: java.io.IOException: Stream frame descriptor corrupted > at org.apache.kafka.common.record.KafkaLZ4BlockInputStream.readHeader(KafkaLZ4BlockInputStream.java:132) > at org.apache.kafka.common.record.KafkaLZ4BlockInputStream.<init>(KafkaLZ4BlockInputStream.java:78) > at org.apache.kafka.common.record.CompressionType$4.wrapForInput(CompressionType.java:110) I will investigate why after, but I want to get the safe fix into 2.4.0. The reporter of KAFKA-9203 has verified that reverting this change makes the problem go away. Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com> (cherry picked from commit f8129f6) Co-authored-by: Ismael Juma <ismael@juma.me.uk>
xvrl
pushed a commit
to xvrl/kafka
that referenced
this pull request
Jul 22, 2021
…ache#6679) lz4/lz4-java#65 was included in lz4-java 1.4.0. Relying on existing tests for verification. Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lz4/lz4-java#65 was included in lz4-java 1.4.0.
Relying on existing tests for verification.
Committer Checklist (excluded from commit message)