[LI-CHERRY-PICK] [f8129f6f] KAFKA-9203: Revert "MINOR: Remove workaro…#84
Merged
Conversation
…nds for lz4-java bug affecting byte buffers (apache#6679)" (apache#7769) TICKET = KAFKA-9203 LI_DESCRIPTION = EXIT_CRITERIA = HASH [f8129f6] ORIGINAL_DESCRIPTION = This reverts commit 90043d5 as it caused a regression in some cases: > Caused by: java.io.IOException: Stream frame descriptor corrupted > at org.apache.kafka.common.record.KafkaLZ4BlockInputStream.readHeader(KafkaLZ4BlockInputStream.java:132) > at org.apache.kafka.common.record.KafkaLZ4BlockInputStream.<init>(KafkaLZ4BlockInputStream.java:78) > at org.apache.kafka.common.record.CompressionType$4.wrapForInput(CompressionType.java:110) I will investigate why after, but I want to get the safe fix into 2.4.0. The reporter of KAFKA-9203 has verified that reverting this change makes the problem go away. Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com> (cherry picked from commit f8129f6)
jonlee2
approved these changes
Jun 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…unds for lz4-java bug affecting byte buffers (apache#6679)" (apache#7769)
TICKET = KAFKA-9203
LI_DESCRIPTION =
EXIT_CRITERIA = HASH [f8129f6]
ORIGINAL_DESCRIPTION =
This reverts commit 90043d5 as it caused a regression in some cases:
I will investigate why after, but I want to get the safe fix into 2.4.0.
The reporter of KAFKA-9203 has verified that reverting this change
makes the problem go away.
Reviewers: Manikumar Reddy manikumar.reddy@gmail.com
(cherry picked from commit f8129f6)