KAFKA-8284: enable static membership on KStream#6673
Merged
Conversation
Member
|
@abbccdda failures seem related |
Author
|
@bbejeck Thanks for the info! |
31ac81d to
91c3ac8
Compare
guozhangwang
reviewed
May 7, 2019
guozhangwang
left a comment
Contributor
There was a problem hiding this comment.
Have some minor questions on whether it is necessary to define this on the streams config level, otherwise lgtm.
| consumerConfigs.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, "none"); | ||
| } | ||
|
|
||
| final String streamGroupInstanceId = config.getString(ConsumerConfig.GROUP_INSTANCE_ID_CONFIG); |
Contributor
There was a problem hiding this comment.
Let's move this logic into getMainConsumerConfigs directly for cleanness?
| "", | ||
| Importance.MEDIUM, | ||
| CLIENT_ID_DOC) | ||
| .define(ConsumerConfig.GROUP_INSTANCE_ID_CONFIG, |
Contributor
There was a problem hiding this comment.
Do we have to define it on the StreamsConfig level?
| Type.STRING, | ||
| null, | ||
| Importance.MEDIUM, | ||
| ConsumerConfig.GROUP_INSTANCE_ID_CONFIG) |
Contributor
There was a problem hiding this comment.
It should be xx_DOC string.
Author
|
Thanks for the review @guozhangwang. Updated the injection path to extract the config value from original consumer config, and refactor the |
guozhangwang
reviewed
May 7, 2019
guozhangwang
left a comment
Contributor
There was a problem hiding this comment.
Just one minor, otherwise lgtm.
We can merge it afterwards and green builds.
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
May 8, 2019
…s-hashcode * apache-github/trunk: KAFKA-8158: Add EntityType for Kafka RPC fields (apache#6503) MINOR: correctly parse version OffsetCommitResponse version < 3 KAFKA-8284: enable static membership on KStream (apache#6673) KAFKA-8304: Fix registration of Connect REST extensions (apache#6651) KAFKA-8275; Take throttling into account when choosing least loaded node (apache#6619) KAFKA-3522: Interactive Queries must return timestamped stores (apache#6661) MINOR: MetricsIntegrationTest should set StreamsConfig.STATE_DIR_CONFIG (apache#6687) MINOR: Remove unused field in `ListenerConnectionQuota` KAFKA-8131; Move --version implementation into CommandLineUtils (apache#6481) KAFKA-8056; Use automatic RPC generation for FindCoordinator (apache#6408) MINOR: Remove workarounds for lz4-java bug affecting byte buffers (apache#6679) KAFKA-7455: Support JmxTool to connect to a secured RMI port. (apache#5968) MINOR: Document improvement (apache#6682) MINOR: Fix ThrottledReplicaListValidator doc error. (apache#6537) KAFKA-8306; Initialize log end offset accurately when start offset is non-zero (apache#6652)
3 tasks
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
Part of KIP-345 effort. The strategy is to extract user passed in group.instance.id config and pass it in with given thread-id (because consumer is currently per-thread level). Reviewers: Guozhang Wang <wangguoz@gmail.com>
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…am (apache#6779) As title states. We plan to merge this to both trunk and 2.3 if it could fix the stream system tests globally. Reference implementation: apache#6673 Reviewers: Guozhang Wang <wangguoz@gmail.com>, Matthias J. Sax <mjsax@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of KIP-345 effort. The strategy is to extract user passed in
group.instance.idconfig and pass it in with given thread-id (because consumer is currently per-thread level).Committer Checklist (excluded from commit message)